From 23b0838e3659b58641b938c266ee02cada39bee4 Mon Sep 17 00:00:00 2001 From: Robin Hahling Date: Tue, 17 Oct 2023 10:34:22 +0200 Subject: [PATCH] ci: update CodeQL action workflow We started seeing failures of the CodeQL job related to an attempted upgrade to Go 1.21. Let's update the CodeQL action workflow loosely based on the cilium/hubble one. Signed-off-by: Robin Hahling --- .github/workflows/codeql-analysis.yml | 69 ++++++++------------------- 1 file changed, 21 insertions(+), 48 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 8bffe77ec..2b5549a9d 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -1,72 +1,45 @@ -# For most projects, this workflow file will not need changing; you simply need -# to commit it to your repository. -# -# You may wish to alter this file to override the set of languages analyzed, -# or to provide custom queries or build logic. -# -# ******** NOTE ******** -# We have attempted to detect the languages in your repository. Please check -# the `language` matrix defined below to confirm you have the correct set of -# supported CodeQL languages. -# -name: "CodeQL" +name: codeql +# Any change in triggers needs to be reflected in the concurrency group. on: push: - branches: [ "master", dev-refactor, v* ] + branches: + - "dev-refactor" + - "master" + - "v*" pull_request: - # The branches below must be a subset of the branches above - branches: [ "master" ] + branches: + - "master" schedule: - - cron: '40 18 * * 0' + - cron: "45 7 * * 3" + +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.event.after || 'scheduled' }} + cancel-in-progress: true jobs: analyze: + if: github.repository == 'cilium/hubble-ui' name: Analyze runs-on: ubuntu-22.04 permissions: actions: read contents: read security-events: write - strategy: fail-fast: false matrix: language: [ 'go', 'javascript' ] - # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ] - # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support - steps: - - name: Checkout repository - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 - - # Initializes the CodeQL tools for scanning. + - name: Checkout repo + uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 + with: + fetch-depth: 1 - name: Initialize CodeQL - uses: github/codeql-action/init@0116bc2df50751f9724a2e35ef1f24d22f90e4e1 + uses: github/codeql-action/init@0116bc2df50751f9724a2e35ef1f24d22f90e4e1 # v2.22.3 with: languages: ${{ matrix.language }} - # If you wish to specify custom queries, you can do so here or in a config file. - # By default, queries listed here will override any specified in a config file. - # Prefix the list here with "+" to use these queries and those in the config file. - - # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs - # queries: security-extended,security-and-quality - - - # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). - # If this step fails, then you should remove it and run the build manually (see below) - name: Autobuild - uses: github/codeql-action/autobuild@0116bc2df50751f9724a2e35ef1f24d22f90e4e1 - - # ℹī¸ Command-line programs to run using the OS shell. - # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun - - # If the Autobuild fails above, remove it and uncomment the following three lines. - # modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance. - - # - run: | - # echo "Run, Build Application using script" - # ./location_of_script_within_repo/buildscript.sh - + uses: github/codeql-action/autobuild@0116bc2df50751f9724a2e35ef1f24d22f90e4e1 # v2.22.3 - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@0116bc2df50751f9724a2e35ef1f24d22f90e4e1 + uses: github/codeql-action/analyze@0116bc2df50751f9724a2e35ef1f24d22f90e4e1 # v2.22.3