-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add traffic drop sub reasons and do validation for those #1046
Comments
@pchaigno do you have other examples? |
Apart from checking the drop reason and direction, it could be good to check the remote security identity. For that last one, it's probably enough to check that it is neither unknown nor a reserved identity unless expected. Checking the exact pod identity is probably overengineering/overtesting. Checking the identity may help us catch cases where we dropped the packets because the identity resolution failed and it should have succeeded but failed to find a corresponding policy rule afterward. Definitely less important than checking the drop reason and direction. |
This commit is to make sure that we can validate if the traffic is dropped for below cases: - Traffic dropped at ingress - Traffic dropped at egress - Traffic dropped by default deny policy Fixes: cilium#1046 Signed-off-by: Tam Mach <[email protected]>
This commit is to make sure that we can validate if the traffic is dropped for below cases: - Traffic dropped at ingress - Traffic dropped at egress - Traffic dropped by default deny policy Fixes: cilium#1046 Signed-off-by: Tam Mach <[email protected]>
This commit is to make sure that we can validate if the traffic is dropped for below cases: - Traffic dropped at ingress - Traffic dropped at egress - Traffic dropped by default deny policy Fixes: cilium#1046 Signed-off-by: Tam Mach <[email protected]>
This commit is to make sure that we can validate if the traffic is dropped for below cases: - Traffic dropped at ingress - Traffic dropped at egress - Traffic dropped by default deny policy Fixes: #1046 Signed-off-by: Tam Mach <[email protected]>
I missed this point in related PR, raised #1100 for tracking purpose. |
This commit is to make sure that we can validate if the traffic is dropped for below cases: - Traffic dropped at ingress - Traffic dropped at egress - Traffic dropped by default deny policy Fixes: cilium#1046 Signed-off-by: Tam Mach <[email protected]>
This commit is to make sure that we can validate if the traffic is dropped for below cases: - Traffic dropped at ingress - Traffic dropped at egress - Traffic dropped by default deny policy Fixes: cilium#1046 Signed-off-by: Tam Mach <[email protected]>
Right now, when doing flow validation, the result only checks if the traffic is dropped:
cilium-cli/connectivity/check/policy.go
Lines 197 to 198 in 1735870
However, traffic can be dropped for multiple reasons such as routing problems, iptables, etc. Thus, we should have sub reasons for why a traffic is dropped so that we can be sure that the end result of a test is actually the one that we should be expecting to see.
Some examples are:
The text was updated successfully, but these errors were encountered: