New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make typechecking after applying default props #181

Open

andrewfan opened this issue Jan 15, 2019 · 0 comments

andrewfan commented Jan 15, 2019 •

edited

Loading

BUG REPORT

Summary

We make typecheking before applying default props

ember-prop-types/addon/mixins/prop-types.js

Line 111 in 2e576c4

helpers.validatePropTypes(this)

In react typecheking happens after it https://reactjs.org/docs/typechecking-with-proptypes.html

Expected Behavior

Typechecking should happend after applying default props

Actual Behavior

Typechecking happens before default props being applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment