Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Clicking too low on the trigger autoselects the first item in the dropdown list #1408

Open
johanrd opened this issue Oct 19, 2020 · 1 comment
Open

Regression: Clicking too low on the trigger autoselects the first item in the dropdown list #1408

johanrd opened this issue Oct 19, 2020 · 1 comment

Comments

@johanrd
Copy link
Contributor

johanrd commented Oct 19, 2020 •
edited
Loading

  1. Go to the current docs for multiselect on v3/v4 and click on the bottom border of the input trigger.
  2. Experience that the first item in the list is selected after a very brief flash of the list:

The same does not happen on the docs for v2 of multiselect, so this seems like a regression.

For debugging, I ran a test with adding margin-top: 1px to .ember-power-select-dropdown, and that made the problem go away. Therefore I suspect this to be an overly triggerhappy mouseup event.

mouse-control-test.js seems to be the guardian for cases like this, however it looks like this has managed to sneek through.
backspace added a commit to cardstack/cardstack that referenced this issue Sep 3, 2021
@backspace
web: Fix Power Select auto-choosing bug
19d2d08 
When I run this locally, it fixes the problem where the prepaid
card chooser in the merchant creation workflow looks like
it’s not opening but is really selecting the first card and
closing.

Thanks to @johanrd for documenting and @Aierie for finding:
cibernox/ember-power-select#1408
@backspace backspace mentioned this issue Sep 3, 2021
Merged
backspace added a commit to cardstack/cardstack that referenced this issue Sep 3, 2021
@backspace
web: Fix Power Select auto-choosing bug (#2040)
f622625 
When I run this locally, it fixes the problem where the prepaid
card chooser in the merchant creation workflow looks like
it’s not opening but is really selecting the first card and
closing.

Thanks to @johanrd for documenting and @Aierie for finding:
cibernox/ember-power-select#1408
@Shadowninja33
Copy link

Shadowninja33 commented Oct 6, 2021 •
edited
Loading

This is occurring in my team's application as well, but the margin-top workaround doesn't seem to work. Are there any updates on resolving this within EPS?

Edit: Quick update. The proposed fix seems to work with the default styles, but not with the included material ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johanrd @Shadowninja33