Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect type for GetPhonebookEntryUID #3

Open
rainmang opened this issue Feb 13, 2022 · 1 comment
Open

incorrect type for GetPhonebookEntryUID #3

rainmang opened this issue Feb 13, 2022 · 1 comment

Comments

@rainmang
Copy link

When running the Test: TestPhonebook() with my FritzBox 7590 using the current firmware, the test crashes inside the following function GetPhonebookEntryUID while deserealizing the XML PhoneBookEntry.
In contacts.cs the variable uniqueidField is defined as a byte.

In my case the value of the uniqueid was 41418, so trying to store that value in a byte caused the error. After changing the type to uint everything worked as expected.
The current AVM document (https://avm.de/fileadmin/user_upload/Global/Service/Schnittstellen/x_contactSCPD.pdf) Page 18 shows that the variable "PhonebookEntryUniqueID" should be defined as ui4.

@chstorb
Copy link
Owner

chstorb commented Oct 26, 2023

I apologize for the delayed reply to your error report. It somehow slipped my attention. - You did a great job of explaining the error. It was not hard to fix it. I have committed the changes. I appreciate your help! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants