Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If plugin is installed but can't be loaded, user shouldn't be prompted to install the plugin again #34

Closed
hyfen opened this issue Mar 15, 2022 · 0 comments
Closed

If plugin is installed but can't be loaded, user shouldn't be prompted to install the plugin again #34

hyfen opened this issue Mar 15, 2022 · 0 comments
Labels
bug Something isn't working plugins Chronicle plugin system

Comments

@hyfen
Copy link
Member

hyfen commented Mar 15, 2022

In PluginRegistry#activate, we can add gem 'chronicle-NAME' and watch for a Gem::MissingSpecError (or maybe via an #installed? method)

Currently, we're only doing require 'chronicle/NAME' which generates a LoadError if the gem is missing OR if the gem fails while loading. This seems to be the problem in #33.
@hyfen hyfen added plugins Chronicle plugin system bug Something isn't working labels Mar 15, 2022
@hyfen hyfen closed this as completed in 966df5e Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working plugins Chronicle plugin system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyfen