From 036307d155e7f33c65b0df792fc024ac35d03a43 Mon Sep 17 00:00:00 2001 From: Nick Harper Date: Wed, 12 Jul 2023 11:50:23 -0700 Subject: [PATCH] Skip more tests that depend on behavior of external domains (#135) Like PR #131, these tests should be fixed as part of issue #112, but in the meantime disabling them so that `make test` passes. --- redirects_test.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/redirects_test.go b/redirects_test.go index 53a4d63..865957c 100644 --- a/redirects_test.go +++ b/redirects_test.go @@ -42,6 +42,10 @@ var tooManyRedirectsTests = []struct { } func TestTooManyRedirects(t *testing.T) { + // Skip this test because it is failing due to relying on behavior of an + // external domain: https://github.com/chromium/hstspreload/issues/112. + t.SkipNow() + skipIfShort(t) t.Parallel() @@ -58,6 +62,10 @@ func TestTooManyRedirects(t *testing.T) { } func TestInsecureRedirect(t *testing.T) { + // Skip this test because it is failing due to relying on behavior of an + // external domain: https://github.com/chromium/hstspreload/issues/112. + t.SkipNow() + skipIfShort(t) t.Parallel() @@ -82,6 +90,10 @@ func TestInsecureRedirect(t *testing.T) { } func TestIndirectInsecureRedirect(t *testing.T) { + // Skip this test because it is failing due to relying on behavior of an + // external domain: https://github.com/chromium/hstspreload/issues/112. + t.SkipNow() + skipIfShort(t) t.Parallel()