Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds FAQ explaining why tests show as new #616

Merged

Conversation

deandre
Copy link
Contributor

@deandre deandre commented Jan 10, 2025

Explain why E2E tests would show as new in builds.

@deandre deandre requested a review from winkerVSbecks January 10, 2025 17:03
@winkerVSbecks
Copy link
Member

@deandre is this meant just for E2E tests or storybook too? If both, could you also include an example of story name changing inside a stories file.

@deandre
Copy link
Contributor Author

deandre commented Jan 15, 2025

@winkerVSbecks the scope of this particular FAQ is E2E tests. it can probably be expanded later to include a CSF example. i've made changes to specify "test" rather than "story" throughout, to avoid confusion.

edit: story names are addressed to an extent by https://www.chromatic.com/docs/faq/why-are-storybook-and-chromatic-story-names-different/

@deandre deandre changed the title Adds FAQ explaining why stories show as new Adds FAQ explaining why tests show as new Jan 15, 2025
@winkerVSbecks
Copy link
Member

Awesome, thank you

@winkerVSbecks winkerVSbecks merged commit 84ac8ec into main Jan 15, 2025
9 checks passed
@winkerVSbecks winkerVSbecks deleted the deandre/sup-246-faq-why-do-tests-show-as-new-in-builds branch January 15, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants