Skip to content

Commit 21da0d6

Browse files
committed
[BLD]: use Blacksmith Windows runners
1 parent 54f45b5 commit 21da0d6

File tree

6 files changed

+38
-25
lines changed

6 files changed

+38
-25
lines changed

.github/workflows/_build_js_bindings.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ name: JS Bindings CI
22
env:
33
DEBUG: napi:*
44
APP_NAME: "chromadb-js-bindings"
5-
MACOSX_DEPLOYMENT_TARGET: '10.13'
5+
MACOSX_DEPLOYMENT_TARGET: "10.13"
66
permissions:
77
contents: write
88
id-token: write
9-
'on':
9+
"on":
1010
workflow_dispatch: {}
1111
workflow_call: {}
1212
jobs:
@@ -75,7 +75,7 @@ jobs:
7575

7676
build-windows:
7777
name: Build Windows bindings
78-
runs-on: 8core-32gb-windows-latest
78+
runs-on: blacksmith-8vcpu-windows-2025
7979
defaults:
8080
run:
8181
working-directory: rust/js_bindings

.github/workflows/_build_release_pypi.yml

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,34 +4,34 @@ on:
44
workflow_dispatch:
55
inputs:
66
publish_to_test_pypi:
7-
description: 'Publish to test PyPI'
7+
description: "Publish to test PyPI"
88
required: false
99
default: false
1010
type: boolean
1111
publish_to_pypi:
12-
description: 'Publish to PyPI'
12+
description: "Publish to PyPI"
1313
required: false
1414
default: false
1515
type: boolean
1616
version:
17-
description: 'Version to publish'
17+
description: "Version to publish"
1818
required: false
1919
type: string
2020

2121
workflow_call:
2222
inputs:
2323
publish_to_test_pypi:
24-
description: 'Publish to test PyPI'
24+
description: "Publish to test PyPI"
2525
required: false
2626
default: false
2727
type: boolean
2828
publish_to_pypi:
29-
description: 'Publish to PyPI'
29+
description: "Publish to PyPI"
3030
required: false
3131
default: false
3232
type: boolean
3333
version:
34-
description: 'Version to publish'
34+
description: "Version to publish"
3535
required: false
3636
type: string
3737

@@ -66,8 +66,12 @@ jobs:
6666
matrix:
6767
platform:
6868
- { os: linux, runner: blacksmith-4vcpu-ubuntu-2404, target: x86_64 }
69-
- { os: linux, runner: blacksmith-4vcpu-ubuntu-2404-arm, target: aarch64 }
70-
- { os: windows, runner: 8core-32gb-windows-latest, target: x64 }
69+
- {
70+
os: linux,
71+
runner: blacksmith-4vcpu-ubuntu-2404-arm,
72+
target: aarch64,
73+
}
74+
- { os: windows, runner: blacksmith-8vcpu-windows-2025, target: x64 }
7175
- { os: macos, runner: macos-14, target: x86_64 }
7276
- { os: macos, runner: macos-14, target: aarch64 }
7377

@@ -176,7 +180,7 @@ jobs:
176180
- name: Generate artifact attestation
177181
uses: actions/attest-build-provenance@v1
178182
with:
179-
subject-path: 'wheels-*/*'
183+
subject-path: "wheels-*/*"
180184

181185
- name: Publish to test PyPI
182186
if: ${{ inputs.publish_to_test_pypi }}

.github/workflows/_python-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ jobs:
263263
fail-fast: false
264264
matrix:
265265
python: ${{ fromJson(inputs.python_versions) }}
266-
runs-on: 8core-32gb-windows-latest
266+
runs-on: blacksmith-8vcpu-windows-2025
267267
steps:
268268
- name: Checkout
269269
uses: actions/checkout@v4

.github/workflows/pr.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,16 @@ jobs:
173173
with:
174174
property_testing_preset: 'normal'
175175

176+
python-tests-windows:
177+
uses: ./.github/workflows/_python-tests.yml
178+
secrets: inherit
179+
with:
180+
# we only run windows tests on 3.12 because windows runners are expensive
181+
# and we usually don't see failures that are isolated to a specific version
182+
python_versions: '["3.12"]'
183+
property_testing_preset: "normal"
184+
runner: blacksmith-8vcpu-windows-2025
185+
176186
python-vulnerability-scan:
177187
name: Python vulnerability scan
178188
needs: change-detection

.github/workflows/release-chromadb.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Set up Python
3636
uses: actions/setup-python@v5
3737
with:
38-
python-version: '3.9'
38+
python-version: "3.9"
3939
- name: Install setuptools_scm
4040
run: python -m pip install setuptools_scm
4141
- name: Get Release Version
@@ -47,7 +47,7 @@ jobs:
4747
secrets: inherit
4848
with:
4949
python_versions: '["3.9", "3.10", "3.11", "3.12"]'
50-
property_testing_preset: 'normal'
50+
property_testing_preset: "normal"
5151

5252
python-tests-windows:
5353
uses: ./.github/workflows/_python-tests.yml
@@ -56,8 +56,8 @@ jobs:
5656
# we only run windows tests on 3.12 because windows runners are expensive
5757
# and we usually don't see failures that are isolated to a specific version
5858
python_versions: '["3.12"]'
59-
property_testing_preset: 'normal'
60-
runner: '8core-32gb-windows-latest'
59+
property_testing_preset: "normal"
60+
runner: blacksmith-8vcpu-windows-2025
6161

6262
javascript-client-tests:
6363
name: JavaScript client tests
@@ -125,7 +125,7 @@ jobs:
125125
- name: Set up Python
126126
uses: ./.github/actions/python
127127
with:
128-
python-version: '3.12'
128+
python-version: "3.12"
129129
- name: Build Client
130130
run: ./clients/python/build_python_thin_client.sh
131131
- name: Test Client Package
@@ -137,13 +137,13 @@ jobs:
137137
with:
138138
password: ${{ secrets.TEST_PYPI_PYTHON_CLIENT_PUBLISH_KEY }}
139139
repository-url: https://test.pypi.org/legacy/
140-
verbose: 'true'
140+
verbose: "true"
141141
- name: Publish to PyPI
142-
if: ${{ needs.check-tag.outputs.tag_matches == 'true' }}
142+
if: ${{ needs.check-tag.outputs.tag_matches == 'true' }}
143143
uses: pypa/gh-action-pypi-publish@release/v1
144144
with:
145145
password: ${{ secrets.PYPI_PYTHON_CLIENT_PUBLISH_KEY }}
146-
verbose: 'true'
146+
verbose: "true"
147147

148148
release-github:
149149
name: Make GitHub release

.github/workflows/release-cli.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
required: false
99
push:
1010
tags:
11-
- 'cli_release_[0-9]*.[0-9]*.[0-9]*'
11+
- "cli_release_[0-9]*.[0-9]*.[0-9]*"
1212

1313
jobs:
1414
build-linux:
@@ -43,7 +43,7 @@ jobs:
4343

4444
build-windows:
4545
name: Build Windows binary
46-
runs-on: 8core-32gb-windows-latest
46+
runs-on: blacksmith-8vcpu-windows-2025
4747
steps:
4848
- name: Checkout repository
4949
uses: actions/checkout@v3
@@ -98,7 +98,6 @@ jobs:
9898
- name: Build macOS Intel binary
9999
run: cargo build --bin chroma --release --target x86_64-apple-darwin --manifest-path rust/cli/Cargo.toml
100100

101-
102101
- name: Build macOS ARM64 binary
103102
run: cargo build --bin chroma --release --target aarch64-apple-darwin --manifest-path rust/cli/Cargo.toml
104103

@@ -123,7 +122,7 @@ jobs:
123122
release:
124123
name: Create GitHub Release and Attach Assets
125124
runs-on: blacksmith-4vcpu-ubuntu-2404
126-
needs: [ build-linux, build-windows, build-macos ]
125+
needs: [build-linux, build-windows, build-macos]
127126
steps:
128127
- name: Checkout repository
129128
uses: actions/checkout@v3

0 commit comments

Comments
 (0)