Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Friendly Names With Spaces Not Parsed When Defining Rooms In Config #82

Open
danieledwardgeorgehitchcock opened this issue Feb 10, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@danieledwardgeorgehitchcock
Copy link

danieledwardgeorgehitchcock commented Feb 10, 2025

Picking up on a thread originally raised in the Discord board, Bifrost does not seem to be able to parse group friendly names which have spaces in them.

I am following the article here for defining rooms in config.yaml here is my config file:

bifrost:
  cert_file: certs/cert.pem

bridge:
  name: Bifrost
  mac: 02:42:ac:15:00:04
  ipaddress: 172.21.0.4
  netmask: 255.255.255.0
  gateway: 172.21.0.1
  timezone: Europe/London

z2m:
  zigbee2mqtt:
    url: ws://zigbee2mqtt:8099/api?token=SUPERSECRETTOKEN

rooms:
  living_room_lights:
    name: Living Room
    icon: living_room
  Office Lights:
    name: Office
    icon: office
  Porch Lights:
    name: Porch
    icon: front_door
  "Master Bedroom Lights":
    name: "Master Bedroom"
    icon: bedroom
  'Dining Room Lights':
    name: 'Dining Room'
    icon: dining
  Patio Lights:
    name: Patio
    icon: terrace
  Garden Lights:
    name: Garden
    icon: garden
  Orangery Lights:
    name: Orangery
    icon: man_cave
  Landing Lights:
    name: Landing
    icon: staircase

Here is an excerpt from the Zigbee2MQTT states.json file:

        "groups": {
            "1": {
                "friendly_name": "living_room_lights"
            },
            "2": {
                "friendly_name": "Office Lights"
            },
            "3": {
                "friendly_name": "Porch Lights"
            },
            "4": {
                "friendly_name": "Master Bedroom Lights"
            },
            "5": {
                "friendly_name": "Dining Room Lights"
            },
            "6": {
                "friendly_name": "Patio Lights"
            },
            "7": {
                "friendly_name": "Garden Lights"
            },
            "8": {
                "friendly_name": "Orangery Lights"
            },
            "9": {
                "friendly_name": "Landing Lights"
            }
        },

Here is an excerpt from the Bifrost log:

2025-02-09T21:21:30.706Z INFO  bifrost::z2m                              > [zigbee2mqtt] room/7d80a811-a16d-5872-883e-03684e5d8753 (Landing Lights) known, updating..
 2025-02-09T21:21:30.706Z INFO  bifrost::z2m                              > [zigbee2mqtt] room/b81a3eb8-ffdc-5197-b1b6-6c79a76ab446 (Orangery Lights) known, updating..
 2025-02-09T21:21:30.706Z INFO  bifrost::z2m                              > [zigbee2mqtt] room/73a10b25-8003-5491-b56c-9f506bcf5414 (Garden Lights) known, updating..
 2025-02-09T21:21:30.706Z INFO  bifrost::z2m                              > [zigbee2mqtt] room/9235bdfb-a79f-570d-947e-be4e090d69d8 (Patio Lights) known, updating..
 2025-02-09T21:21:30.706Z INFO  bifrost::z2m                              > [zigbee2mqtt] room/9637a1c9-0be0-5b07-8129-0fb420e30acb (Dining Room Lights) known, updating..
 2025-02-09T21:21:30.706Z INFO  bifrost::z2m                              > [zigbee2mqtt] room/7dd91229-3b60-542e-aba3-8e5fe786bd28 (Master Bedroom Lights) known, updating..
 2025-02-09T21:21:30.706Z INFO  bifrost::z2m                              > [zigbee2mqtt] room/9fdd781c-a38a-5500-929d-5160bec8fc1e (Porch Lights) known, updating..
 2025-02-09T21:21:30.706Z INFO  bifrost::z2m                              > [zigbee2mqtt] room/94036978-bc1e-5e2c-b3f9-a0fd7a58f1d4 (Office Lights) known, updating..
 2025-02-09T21:21:30.706Z INFO  bifrost::z2m                              > [zigbee2mqtt] room/f076c21a-b417-5f0b-ab6a-87cc9e2c5075 (living_room_lights) known, updating..

Out of the above config, the only Zigbee2MQTT group which is correctly parsed by Bifrost into a room is living_room_lights.

I have tried completely removing and rebuilding Bifrost (Docker), removing all cache and user data from the Hue app, and everything in-between.

@chrivers chrivers added the bug Something isn't working label Mar 16, 2025
@chrivers
Copy link
Owner

Hi @danieledwardgeorgehitchcock

Thanks for reporting this. As we talked about, this is definitely a bug in Bifrost, somehow.

Good, detailed description 👍 We'll keep this open until I get around to it :)

@danieledwardgeorgehitchcock
Copy link
Author

@chrivers - This seems to have been fixed (not sure if on purpose) in a recent release of Bifrost (not sure which one)

Will leave open for now so we can close with reference back to a PR / Commit...

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants