Skip to content

Commit abd1071

Browse files
chrisbobbechrisbobbe
committed
page: Split empty-page placeholder messages into header and message
Following a new Figma frame that specifies larger text for the first part: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=11194-18392&m=dev
1 parent 343102d commit abd1071

22 files changed

+307
-191
lines changed

‎assets/l10n/app_en.arb‎

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@
8080
"@allChannelsPageTitle": {
8181
"description": "Title for the 'All channels' page."
8282
},
83-
"allChannelsEmptyPlaceholder": "There are no channels you can view in this organization.",
84-
"@allChannelsEmptyPlaceholder": {
83+
"allChannelsEmptyPlaceholderHeader": "There are no channels you can view in this organization.",
84+
"@allChannelsEmptyPlaceholderHeader": {
8585
"description": "Centered text on the 'All channels' page saying that there is no content to show."
8686
},
8787
"profileButtonSendDirectMessage": "Send direct message",
@@ -1090,10 +1090,14 @@
10901090
"@inboxPageTitle": {
10911091
"description": "Title for the page with unreads."
10921092
},
1093-
"inboxEmptyPlaceholder": "There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.",
1094-
"@inboxEmptyPlaceholder": {
1093+
"inboxEmptyPlaceholderHeader": "There are no unread messages in your inbox.",
1094+
"@inboxEmptyPlaceholderHeader": {
10951095
"description": "Centered text on the 'Inbox' page saying that there is no content to show."
10961096
},
1097+
"inboxEmptyPlaceholderMessage": "Use the buttons below to view the combined feed or list of channels.",
1098+
"@inboxEmptyPlaceholderMessage": {
1099+
"description": "Additional centered text on the 'Inbox' page saying that there is no content to show."
1100+
},
10971101
"recentDmConversationsPageTitle": "Direct messages",
10981102
"@recentDmConversationsPageTitle": {
10991103
"description": "Title for the page with a list of DM conversations."
@@ -1102,10 +1106,14 @@
11021106
"@recentDmConversationsSectionHeader": {
11031107
"description": "Heading for direct messages section on the 'Inbox' message view."
11041108
},
1105-
"recentDmConversationsEmptyPlaceholder": "You have no direct messages yet! Why not start the conversation?",
1106-
"@recentDmConversationsEmptyPlaceholder": {
1109+
"recentDmConversationsEmptyPlaceholderHeader": "You have no direct messages yet!",
1110+
"@recentDmConversationsEmptyPlaceholderHeader": {
11071111
"description": "Centered text on the 'Direct messages' page saying that there is no content to show."
11081112
},
1113+
"recentDmConversationsEmptyPlaceholderMessage": "Why not start the conversation?",
1114+
"@recentDmConversationsEmptyPlaceholderMessage": {
1115+
"description": "Additional centered text on the 'Direct messages' page saying that there is no content to show."
1116+
},
11091117
"combinedFeedPageTitle": "Combined feed",
11101118
"@combinedFeedPageTitle": {
11111119
"description": "Page title for the 'Combined feed' message view."
@@ -1122,12 +1130,12 @@
11221130
"@channelsPageTitle": {
11231131
"description": "Title for the page with a list of subscribed channels."
11241132
},
1125-
"channelsEmptyPlaceholder": "You’re not subscribed to any channels yet.",
1126-
"@channelsEmptyPlaceholder": {
1133+
"channelsEmptyPlaceholderHeader": "You’re not subscribed to any channels yet.",
1134+
"@channelsEmptyPlaceholderHeader": {
11271135
"description": "Centered text on the 'Channels' page saying that there is no content to show."
11281136
},
1129-
"channelsEmptyPlaceholderWithAllChannelsLink": "You’re not subscribed to any channels yet. Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.",
1130-
"@channelsEmptyPlaceholderWithAllChannelsLink": {
1137+
"channelsEmptyPlaceholderMessage": "You’re not subscribed to any channels yet. Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.",
1138+
"@channelsEmptyPlaceholderMessage": {
11311139
"description": "Centered text on the 'Channels' page saying that there is no content to show, with a link to 'All channels'.",
11321140
"placeholders": {
11331141
"allChannelsPageTitle": {"type": "String", "example": "All channels"}

‎lib/generated/l10n/zulip_localizations.dart‎

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ abstract class ZulipLocalizations {
255255
///
256256
/// In en, this message translates to:
257257
/// **'There are no channels you can view in this organization.'**
258-
String get allChannelsEmptyPlaceholder;
258+
String get allChannelsEmptyPlaceholderHeader;
259259

260260
/// Label for button in profile screen to navigate to DMs with the shown user.
261261
///
@@ -1612,8 +1612,14 @@ abstract class ZulipLocalizations {
16121612
/// Centered text on the 'Inbox' page saying that there is no content to show.
16131613
///
16141614
/// In en, this message translates to:
1615-
/// **'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.'**
1616-
String get inboxEmptyPlaceholder;
1615+
/// **'There are no unread messages in your inbox.'**
1616+
String get inboxEmptyPlaceholderHeader;
1617+
1618+
/// Additional centered text on the 'Inbox' page saying that there is no content to show.
1619+
///
1620+
/// In en, this message translates to:
1621+
/// **'Use the buttons below to view the combined feed or list of channels.'**
1622+
String get inboxEmptyPlaceholderMessage;
16171623

16181624
/// Title for the page with a list of DM conversations.
16191625
///
@@ -1630,8 +1636,14 @@ abstract class ZulipLocalizations {
16301636
/// Centered text on the 'Direct messages' page saying that there is no content to show.
16311637
///
16321638
/// In en, this message translates to:
1633-
/// **'You have no direct messages yet! Why not start the conversation?'**
1634-
String get recentDmConversationsEmptyPlaceholder;
1639+
/// **'You have no direct messages yet!'**
1640+
String get recentDmConversationsEmptyPlaceholderHeader;
1641+
1642+
/// Additional centered text on the 'Direct messages' page saying that there is no content to show.
1643+
///
1644+
/// In en, this message translates to:
1645+
/// **'Why not start the conversation?'**
1646+
String get recentDmConversationsEmptyPlaceholderMessage;
16351647

16361648
/// Page title for the 'Combined feed' message view.
16371649
///
@@ -1661,15 +1673,13 @@ abstract class ZulipLocalizations {
16611673
///
16621674
/// In en, this message translates to:
16631675
/// **'You’re not subscribed to any channels yet.'**
1664-
String get channelsEmptyPlaceholder;
1676+
String get channelsEmptyPlaceholderHeader;
16651677

16661678
/// Centered text on the 'Channels' page saying that there is no content to show, with a link to 'All channels'.
16671679
///
16681680
/// In en, this message translates to:
16691681
/// **'You’re not subscribed to any channels yet. Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.'**
1670-
String channelsEmptyPlaceholderWithAllChannelsLink(
1671-
String allChannelsPageTitle,
1672-
);
1682+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle);
16731683

16741684
/// Title for the page about sharing content received from other apps.
16751685
///

‎lib/generated/l10n/zulip_localizations_ar.dart‎

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
7474
String get allChannelsPageTitle => 'All channels';
7575

7676
@override
77-
String get allChannelsEmptyPlaceholder =>
77+
String get allChannelsEmptyPlaceholderHeader =>
7878
'There are no channels you can view in this organization.';
7979

8080
@override
@@ -911,8 +911,12 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
911911
String get inboxPageTitle => 'Inbox';
912912

913913
@override
914-
String get inboxEmptyPlaceholder =>
915-
'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.';
914+
String get inboxEmptyPlaceholderHeader =>
915+
'There are no unread messages in your inbox.';
916+
917+
@override
918+
String get inboxEmptyPlaceholderMessage =>
919+
'Use the buttons below to view the combined feed or list of channels.';
916920

917921
@override
918922
String get recentDmConversationsPageTitle => 'Direct messages';
@@ -921,8 +925,12 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
921925
String get recentDmConversationsSectionHeader => 'Direct messages';
922926

923927
@override
924-
String get recentDmConversationsEmptyPlaceholder =>
925-
'You have no direct messages yet! Why not start the conversation?';
928+
String get recentDmConversationsEmptyPlaceholderHeader =>
929+
'You have no direct messages yet!';
930+
931+
@override
932+
String get recentDmConversationsEmptyPlaceholderMessage =>
933+
'Why not start the conversation?';
926934

927935
@override
928936
String get combinedFeedPageTitle => 'Combined feed';
@@ -937,13 +945,11 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
937945
String get channelsPageTitle => 'Channels';
938946

939947
@override
940-
String get channelsEmptyPlaceholder =>
948+
String get channelsEmptyPlaceholderHeader =>
941949
'You’re not subscribed to any channels yet.';
942950

943951
@override
944-
String channelsEmptyPlaceholderWithAllChannelsLink(
945-
String allChannelsPageTitle,
946-
) {
952+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
947953
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
948954
}
949955

‎lib/generated/l10n/zulip_localizations_de.dart‎

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
7474
String get allChannelsPageTitle => 'All channels';
7575

7676
@override
77-
String get allChannelsEmptyPlaceholder =>
77+
String get allChannelsEmptyPlaceholderHeader =>
7878
'There are no channels you can view in this organization.';
7979

8080
@override
@@ -935,8 +935,12 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
935935
String get inboxPageTitle => 'Eingang';
936936

937937
@override
938-
String get inboxEmptyPlaceholder =>
939-
'Es sind keine ungelesenen Nachrichten in deinem Eingang. Verwende die Buttons unten, um den kombinierten Feed oder die Kanalliste anzusehen.';
938+
String get inboxEmptyPlaceholderHeader =>
939+
'There are no unread messages in your inbox.';
940+
941+
@override
942+
String get inboxEmptyPlaceholderMessage =>
943+
'Use the buttons below to view the combined feed or list of channels.';
940944

941945
@override
942946
String get recentDmConversationsPageTitle => 'Direktnachrichten';
@@ -945,8 +949,12 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
945949
String get recentDmConversationsSectionHeader => 'Direktnachrichten';
946950

947951
@override
948-
String get recentDmConversationsEmptyPlaceholder =>
949-
'Du hast noch keine Direktnachrichten! Warum nicht die Unterhaltung beginnen?';
952+
String get recentDmConversationsEmptyPlaceholderHeader =>
953+
'You have no direct messages yet!';
954+
955+
@override
956+
String get recentDmConversationsEmptyPlaceholderMessage =>
957+
'Why not start the conversation?';
950958

951959
@override
952960
String get combinedFeedPageTitle => 'Kombinierter Feed';
@@ -961,12 +969,11 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
961969
String get channelsPageTitle => 'Kanäle';
962970

963971
@override
964-
String get channelsEmptyPlaceholder => 'Du hast noch keine Kanäle abonniert.';
972+
String get channelsEmptyPlaceholderHeader =>
973+
'You’re not subscribed to any channels yet.';
965974

966975
@override
967-
String channelsEmptyPlaceholderWithAllChannelsLink(
968-
String allChannelsPageTitle,
969-
) {
976+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
970977
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
971978
}
972979

‎lib/generated/l10n/zulip_localizations_en.dart‎

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
7474
String get allChannelsPageTitle => 'All channels';
7575

7676
@override
77-
String get allChannelsEmptyPlaceholder =>
77+
String get allChannelsEmptyPlaceholderHeader =>
7878
'There are no channels you can view in this organization.';
7979

8080
@override
@@ -911,8 +911,12 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
911911
String get inboxPageTitle => 'Inbox';
912912

913913
@override
914-
String get inboxEmptyPlaceholder =>
915-
'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.';
914+
String get inboxEmptyPlaceholderHeader =>
915+
'There are no unread messages in your inbox.';
916+
917+
@override
918+
String get inboxEmptyPlaceholderMessage =>
919+
'Use the buttons below to view the combined feed or list of channels.';
916920

917921
@override
918922
String get recentDmConversationsPageTitle => 'Direct messages';
@@ -921,8 +925,12 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
921925
String get recentDmConversationsSectionHeader => 'Direct messages';
922926

923927
@override
924-
String get recentDmConversationsEmptyPlaceholder =>
925-
'You have no direct messages yet! Why not start the conversation?';
928+
String get recentDmConversationsEmptyPlaceholderHeader =>
929+
'You have no direct messages yet!';
930+
931+
@override
932+
String get recentDmConversationsEmptyPlaceholderMessage =>
933+
'Why not start the conversation?';
926934

927935
@override
928936
String get combinedFeedPageTitle => 'Combined feed';
@@ -937,13 +945,11 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
937945
String get channelsPageTitle => 'Channels';
938946

939947
@override
940-
String get channelsEmptyPlaceholder =>
948+
String get channelsEmptyPlaceholderHeader =>
941949
'You’re not subscribed to any channels yet.';
942950

943951
@override
944-
String channelsEmptyPlaceholderWithAllChannelsLink(
945-
String allChannelsPageTitle,
946-
) {
952+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
947953
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
948954
}
949955

‎lib/generated/l10n/zulip_localizations_fr.dart‎

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
7575
String get allChannelsPageTitle => 'All channels';
7676

7777
@override
78-
String get allChannelsEmptyPlaceholder =>
78+
String get allChannelsEmptyPlaceholderHeader =>
7979
'There are no channels you can view in this organization.';
8080

8181
@override
@@ -925,8 +925,12 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
925925
String get inboxPageTitle => 'Inbox';
926926

927927
@override
928-
String get inboxEmptyPlaceholder =>
929-
'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.';
928+
String get inboxEmptyPlaceholderHeader =>
929+
'There are no unread messages in your inbox.';
930+
931+
@override
932+
String get inboxEmptyPlaceholderMessage =>
933+
'Use the buttons below to view the combined feed or list of channels.';
930934

931935
@override
932936
String get recentDmConversationsPageTitle => 'Direct messages';
@@ -935,8 +939,12 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
935939
String get recentDmConversationsSectionHeader => 'Direct messages';
936940

937941
@override
938-
String get recentDmConversationsEmptyPlaceholder =>
939-
'You have no direct messages yet! Why not start the conversation?';
942+
String get recentDmConversationsEmptyPlaceholderHeader =>
943+
'You have no direct messages yet!';
944+
945+
@override
946+
String get recentDmConversationsEmptyPlaceholderMessage =>
947+
'Why not start the conversation?';
940948

941949
@override
942950
String get combinedFeedPageTitle => 'Combined feed';
@@ -951,13 +959,11 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
951959
String get channelsPageTitle => 'Channels';
952960

953961
@override
954-
String get channelsEmptyPlaceholder =>
962+
String get channelsEmptyPlaceholderHeader =>
955963
'You’re not subscribed to any channels yet.';
956964

957965
@override
958-
String channelsEmptyPlaceholderWithAllChannelsLink(
959-
String allChannelsPageTitle,
960-
) {
966+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
961967
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
962968
}
963969

‎lib/generated/l10n/zulip_localizations_it.dart‎

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
7474
String get allChannelsPageTitle => 'All channels';
7575

7676
@override
77-
String get allChannelsEmptyPlaceholder =>
77+
String get allChannelsEmptyPlaceholderHeader =>
7878
'There are no channels you can view in this organization.';
7979

8080
@override
@@ -926,8 +926,12 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
926926
String get inboxPageTitle => 'Inbox';
927927

928928
@override
929-
String get inboxEmptyPlaceholder =>
930-
'Non ci sono messaggi non letti nella posta in arrivo. Usare i pulsanti sotto per visualizzare il feed combinato o l\'elenco dei canali.';
929+
String get inboxEmptyPlaceholderHeader =>
930+
'There are no unread messages in your inbox.';
931+
932+
@override
933+
String get inboxEmptyPlaceholderMessage =>
934+
'Use the buttons below to view the combined feed or list of channels.';
931935

932936
@override
933937
String get recentDmConversationsPageTitle => 'Messaggi diretti';
@@ -936,8 +940,12 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
936940
String get recentDmConversationsSectionHeader => 'Messaggi diretti';
937941

938942
@override
939-
String get recentDmConversationsEmptyPlaceholder =>
940-
'Non ci sono ancora messaggi diretti! Perché non iniziare la conversazione?';
943+
String get recentDmConversationsEmptyPlaceholderHeader =>
944+
'You have no direct messages yet!';
945+
946+
@override
947+
String get recentDmConversationsEmptyPlaceholderMessage =>
948+
'Why not start the conversation?';
941949

942950
@override
943951
String get combinedFeedPageTitle => 'Feed combinato';
@@ -952,13 +960,11 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
952960
String get channelsPageTitle => 'Canali';
953961

954962
@override
955-
String get channelsEmptyPlaceholder =>
956-
'Non sei ancora iscritto ad alcun canale.';
963+
String get channelsEmptyPlaceholderHeader =>
964+
'You’re not subscribed to any channels yet.';
957965

958966
@override
959-
String channelsEmptyPlaceholderWithAllChannelsLink(
960-
String allChannelsPageTitle,
961-
) {
967+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
962968
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
963969
}
964970

0 commit comments

Comments
 (0)