Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Toast notifications to stack #428

Closed
6 tasks done
st3phhays opened this issue Nov 15, 2024 · 0 comments
Closed
6 tasks done

Allow Toast notifications to stack #428

st3phhays opened this issue Nov 15, 2024 · 0 comments
Assignees
@st3phhays
Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member Accessibility Represents issues that are related to accessibility in UI such as WCAG, etc. Bug Issues where something has happened which was not expected or intended ChocolateyCentralManagement

Comments

@st3phhays
Copy link
Member

st3phhays commented Nov 15, 2024 •
edited by sync-by-unito bot
Loading

Checklist

  • I confirm there are no unresolved issues reported on the Chocolatey Status page.
  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.
  • I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?

Toast notifications use one element which the text is appended to every time a new notification needs shown. In most cases, this is fine, but it becomes a problem if more than one Toast notification needs to be shown at a time. For instance, maybe two operations were done back to back, and they both need either a success/fail notification.

What is Expected?

Toast notification should be added one by one when they are needed. After they have been dismissed (either manually, or after the time limit), then they should be removed from the dom. This will allow Toast notifications to stack, and more than one to be shown at a time.

How Did You Get This To Happen?

I ran into this issue when needing to save a Deployment Step and show a "Saved Success Message" and then immediately go to duplicate a Step and show an other "Successful Duplication" message. When doing this, the first notification was immediately replaced, and was unable to be seen or announced by screen readers.

System Details

choco-theme 0.13.1

Installed Packages

n/a

Output Log

n/a

Additional Context

No response

┆Issue is synchronized with this Gitlab issue by Unito
@st3phhays st3phhays added the Bug Issues where something has happened which was not expected or intended label Nov 15, 2024
@st3phhays st3phhays self-assigned this Nov 15, 2024
@st3phhays st3phhays added 2 - Working A user or team member has started working on the issue Accessibility Represents issues that are related to accessibility in UI such as WCAG, etc. ChocolateyCentralManagement labels Nov 15, 2024
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Nov 15, 2024
@st3phhays
(chocolatey#428) Allow Toast notifications to stack
233ee83
@st3phhays st3phhays changed the title All Toast notifications to stack Allow Toast notifications to stack Nov 15, 2024
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Nov 20, 2024
@st3phhays
(chocolatey#428) Allow Toast notifications to stack
b5a7da6
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Nov 21, 2024
@st3phhays
(chocolatey#428) Allow Toast notifications to stack
df6df54
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Nov 21, 2024
@st3phhays
(chocolatey#428) Allow Toast notifications to stack
21b304e 
This allows multiple Toast notifications to stack
on top of each other. They are only removed from
the dom after the `hide` callback is triggered.
This gives the user the ability to see all of the
notifications that have been triggered.
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Nov 21, 2024
@st3phhays
(chocolatey#428) Allow Toast notifications to stack
052b9b9 
This allows multiple Toast notifications to stack
on top of each other. They are only removed from
the dom after the `hide` callback is triggered.
This gives the user the ability to see all of the
notifications that have been triggered.
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Dec 3, 2024
@st3phhays
(chocolatey#428) Allow Toast notifications to stack
a3ac0e9 
This allows multiple Toast notifications to stack
on top of each other. They are only removed from
the dom after the `hide` callback is triggered.
This gives the user the ability to see all of the
notifications that have been triggered.
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Dec 6, 2024
@st3phhays
(chocolatey#428) Allow Toast notifications to stack
29414c6 
This allows multiple Toast notifications to stack
on top of each other. They are only removed from
the dom after the `hide` callback is triggered.
This gives the user the ability to see all of the
notifications that have been triggered.
@st3phhays st3phhays added 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint and removed 2 - Working A user or team member has started working on the issue labels Dec 6, 2024
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Dec 10, 2024
@st3phhays
(chocolatey#428) Allow Toast notifications to stack
efde5f9 
This allows multiple Toast notifications to stack
on top of each other. They are only removed from
the dom after the `hide` callback is triggered.
This gives the user the ability to see all of the
notifications that have been triggered.
@st3phhays st3phhays added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint labels Dec 17, 2024
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Jan 14, 2025
@st3phhays
(chocolatey#428) Allow Toast notifications to stack
cfeeeeb 
This allows multiple Toast notifications to stack
on top of each other. They are only removed from
the dom after the `hide` callback is triggered.
This gives the user the ability to see all of the
notifications that have been triggered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st3phhays st3phhays

Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member Accessibility Represents issues that are related to accessibility in UI such as WCAG, etc. Bug Issues where something has happened which was not expected or intended ChocolateyCentralManagement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@st3phhays