Fix advisor query logic #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some scholars were being identified as advisees on their advisors page, but did not have an advisor on their own page. For example, Sam Lebovic was listed as an advisee of Amy Dru Stanley's page, but did not have an advisor listed on his page.
To correct this, the Scholar page now queries for the advisor through matching dissertations in the dissertation and committee member tables. This change was done for both the Scholar's displayed information as well as in the visualization APIs.
For longevity, the query logic was also changed by switching from using aha_scholar_id to scholar_id. This will be more robust when non-AHA data is added to the dataset. This was changed in the scholar's template as well as in the tree visualization APIs.