Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor into npm module; publish on npm #34

Open
multimeric opened this issue May 5, 2019 · 3 comments
Open

Refactor into npm module; publish on npm #34

multimeric opened this issue May 5, 2019 · 3 comments

Comments

@multimeric
Copy link

I'm interested in using this tool for a webpack-based project, but for that it would work best if this library was provided as an npm module. Are you interested in a PR to this end?

@chmille4
Copy link
Owner

chmille4 commented May 5, 2019

Would be very happy to have it.

@multimeric
Copy link
Author

Excellent! I'm almost there, I just have one issue. Webpack expects libraries to exported as a single namespace (Scribl in this case), meaning that all the different classes would have to be instantiated using that namespace:

const chart = new Scribl.Scribl(canvas, 500);
const gene1 = track1.addFeature(new Scribl.BlockArrow('track1', 5, 750 , '-'));

This would mean changing some of the examples and documentation. Is that workable?

@chmille4
Copy link
Owner

chmille4 commented May 5, 2019

It's a breaking change, but I think it's work it to have it as an npm module. So it's good with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants