Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix over-ridden compiler options in boards.txt for -G1024 #621

Open
EmbeddedMan opened this issue Oct 21, 2015 · 3 comments
Open

Fix over-ridden compiler options in boards.txt for -G1024 #621

EmbeddedMan opened this issue Oct 21, 2015 · 3 comments

Comments

@EmbeddedMan
Copy link
Member

Many of the boards in boards.txt that have 64K RAM or less (which is most of our boards at this point) can benefit from the -G1024 compiler options (so says Jason, and I'd believe him), and we are not currently overriding the default compiler flags (in platforms.txt) for all of these boards.

So fix it, darn it.

EmbeddedMan added a commit to EmbeddedMan/chipKIT32-MAX that referenced this issue Oct 21, 2015
…latforms.txt) for all of the boards that could use it.
EmbeddedMan added a commit to EmbeddedMan/chipKIT32-MAX that referenced this issue Oct 21, 2015
…ary in the overridden compiler flags in boards.txt.

Fix for issue chipKIT32#621: remove all plib.h references.
@EmbeddedMan
Copy link
Member Author

Ended up realizing that we need to change the variant level boards.txt file to affect this change properly. Removing the top level boards.txt will prevent confusion in the future. All of the boards that need this -G1024 option also need their custom compiler flags updated with the values from platforms.txt.

EmbeddedMan added a commit that referenced this issue Oct 22, 2015
Fix for issue #621 : Add -G1024 compiler flags (overriding platforms.…
@ricklon
Copy link
Member

ricklon commented Oct 22, 2015

Good idea!

On Wed, Oct 21, 2015, 7:45 PM Brian Schmalz [email protected]
wrote:

Ended up realizing that we need to change the variant level boards.txt
file to affect this change properly. Removing the top level boards.txt will
prevent confusion in the future. All of the boards that need this -G1024
option also need their custom compiler flags updated with the values from
platforms.txt.


Reply to this email directly or view it on GitHub
#621 (comment)
.

@EmbeddedMan
Copy link
Member Author

I just realized why removing the boards.txt is not a good idea. When we get the code working to pull chipKIT-core into MPIDE when we do a build (rather than have separate core files like we do now) then this file will come back.

In any case, the original issue should now be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants