Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent boards.txt chipKIT Files #561

Open
rei-vilo opened this issue Apr 9, 2015 · 7 comments
Open

Inconsistent boards.txt chipKIT Files #561

rei-vilo opened this issue Apr 9, 2015 · 7 comments

Comments

@rei-vilo
Copy link
Contributor

rei-vilo commented Apr 9, 2015

All the boards.txt files for the chipKIT mention compiler.c.flags and compiler.cpp.flags, except the WiFire, WF32 and Max32.

uno_pic32.compiler.c.flags=-O2::-c::-mno-smart-io::-w::-ffunction-sections::-fdata-sections::-G1024::-g::-mdebugger::-Wcast-align::-fno-short-double
uno_pic32.compiler.cpp.flags=-O2::-c::-mno-smart-io::-w::-fno-exceptions::-ffunction-sections::-fdata-sections::-G1024::-g::-mdebugger::-Wcast-align::-fno-short-double

Please add those two missing entries to the 3 boards.

@ricklon
Copy link
Member

ricklon commented Apr 10, 2015

Thanks for finding that. Can do.

@rei-vilo
Copy link
Contributor Author

You're welcome! I've included a patch on my embedXcode makefiles to cope with this.

Shouldn't chipkit_WiFire.upload.maximum_size be 2 MB as advertised and not 512 KB?

chipkit_WiFire.upload.maximum_size=2097152

instead of

chipkit_WiFire.upload.maximum_size=520192

@ricklon
Copy link
Member

ricklon commented Apr 11, 2015

I'll check with Keith about that value, but it should.

@KeithV
Copy link

KeithV commented Jun 15, 2015

The compiler options come from platforms.txt and do not need to be overridden in boards.txt, so this is not an error. The flash size is an error and is 2^^21 - 2^^14 (MZ have 16K pages, not 4K pages). The actual flash size is 2080768.

@rei-vilo
Copy link
Contributor Author

So, in that case, let's wipe the compiler.c.flags and compiler.cpp.flagsout of the boards.txt for better clarity.

@ricklon
Copy link
Member

ricklon commented Jun 16, 2015

Good idea. If it's not actively maintained or there for a reason it should
go away because it will hide fixes or changes that happen in platforms.txt.

On Tue, Jun 16, 2015 at 12:49 AM, Rei Vilo [email protected] wrote:

So, in that case, wipe the compiler.c.flags and compiler.cpp.flagsout of
the boards.txt for better clarity.


Reply to this email directly or view it on GitHub
#561 (comment)
.

Co-founder
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

@EmbeddedMan
Copy link
Member

OK, at this point there are default compiler.c.flags and compiler.cpp.flags in the platforms.txt file, and then there are over-ridden values in boards.txt for any board that can benefit from the -G1024 compiler option. (which turns out to be most of them). At this point I feel like this issue has been taken as far as it needs to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants