Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino packaging must be in a single folder #17

Open
majenkotech opened this issue Aug 31, 2020 · 1 comment
Open

Arduino packaging must be in a single folder #17

majenkotech opened this issue Aug 31, 2020 · 1 comment

Comments

@majenkotech
Copy link
Member

A requirement for using the arduino-cli is that the compiler archive must contain only one root folder. At the moment the compiler is packaged as a tar file from inside the top level folder, rather than including that top level folder.

An example of how it should be:

$ tar -ztvf pic32-tools-143-3-Linux32-image.tar.gz 
drwxr-xr-x matt/matt         0 2017-04-27 21:44 pic32-tools-143/
drwxr-xr-x matt/matt         0 2017-04-27 21:44 pic32-tools-143/lib/
drwxr-xr-x matt/matt         0 2017-04-27 21:44 pic32-tools-143/lib/gcc/
drwxr-xr-x matt/matt         0 2017-04-27 21:44 pic32-tools-143/lib/gcc/pic32mx/
drwxr-xr-x matt/matt         0 2017-04-27 21:44 pic32-tools-143/lib/gcc/pic32mx/4.8.3/
drwxr-xr-x matt/matt         0 2017-04-27 21:44 pic32-tools-143/lib/gcc/pic32mx/4.8.3/micromips/
-rw-r--r-- matt/matt       795 2017-03-13 17:01 pic32-tools-143/lib/gcc/pic32mx/4.8.3/micromips/crtn.o
... etc ...

Converting one of the existing builds is easy enough:

$ mkdir pic32-tools-143
$ tar -C pic32-tools-143 -zxf pic32-tools-143-3-Linux32-image.tar.gz
$ tar -zcf pic32-tools-143-3-Linux32-image.tar.gz pic32-tools-143

And of course the file size and SHA-256 checksum will change so the JSON file will need to be updated with those new details.

@EmbeddedMan
Copy link
Member

@jasonkajita @geoffwozniak-mchp Would the simplest way to fix this problem be to update the scripts you use to build the compiler outputs and then kick out a new release? I see that in chipKIT-compiler-builds repo we have a 1.43-4 "Pre-release" (from Apr 24 2018) in the releases section (which adds GDB support) but we haven't updated the chipkit JASON file to point to 143-4 yet.

I'm sure I can just download each compiler-build .tar.gz files, add the top level folder, then tar.gz them back up and upload as a new release. But that seems like a poor band-aid. To update the script(s) so that they will always be built properly in the future, then do a new release seems like the better choice. But I don't know how do do that - we will need you to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants