Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min-height: 100vh buggy in safari (iOS) #48

Open
diaasaur opened this issue Oct 16, 2023 · 0 comments
Open

min-height: 100vh buggy in safari (iOS) #48

diaasaur opened this issue Oct 16, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@diaasaur
Copy link
Contributor

diaasaur commented Oct 16, 2023

min-height: 100vh was added to make sure that the minimum height of the app (root) takes 100% of the viewport height BUT looks like webkit has issues with this - I see additional height being added, which is does not look good. this is a known issue and I thought min-height: 100dvh might fix it, but it did not.

need to do research on:

  • why webkit behaves this way
  • how to reliably fix it (look into why dvh did not work here, try out height:-webkit-fill-available;)
  • prefer a css fix instead of using js
@diaasaur diaasaur added the bug Something isn't working label Oct 16, 2023
@diaasaur diaasaur self-assigned this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant