From 19967d4b925df4039cf295f1fd51619f05a22b16 Mon Sep 17 00:00:00 2001 From: smiley Date: Fri, 8 Mar 2024 20:14:30 +0100 Subject: [PATCH] :octocat: --- .github/PULL_REQUEST_TEMPLATE.md | 8 +++++--- .github/workflows/ci.yml | 29 ++++++++++++++--------------- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7afaed33..5b454855 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,11 +1,11 @@ - - ## Proposed changes + + ## Types of changes @@ -15,6 +15,8 @@ What types of changes does your code introduce? - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) +- [ ] Documentation fix or enhancement (no code was touched) +- [ ] Other (CI, dependencies, etc., please describe) ## Checklist: @@ -23,7 +25,7 @@ What types of changes does your code introduce? - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged and published in downstream modules -- [ ] Lint and unit tests pass locally with my changes +- [ ] Static analysis and unit tests pass locally with my changes ## Further comments diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 65820b31..1dfedad6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,5 +1,5 @@ -# https://help.github.com/en/categories/automating-your-workflow-with-github-actions -# https://github.com/sebastianbergmann/phpunit/blob/master/.github/workflows/ci.yml +# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions +# https://github.com/sebastianbergmann/phpunit/blob/main/.github/workflows/ci.yaml name: "Continuous Integration" @@ -11,6 +11,11 @@ on: branches: - main +env: + PHP_EXTENSIONS: ast, curl, fileinfo, intl, json, mbstring, simplexml, sodium, zlib + PHP_INI_VALUES: memory_limit=-1, error_reporting=-1, display_errors=On + + jobs: static-code-analysis: @@ -37,9 +42,10 @@ jobs: uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php-version }} + extensions: ${{ env.PHP_EXTENSIONS }} + ini-values: ${{ env.PHP_INI_VALUES }} tools: pecl coverage: none - extensions: ast, curl, fileinfo, intl, json, mbstring, simplexml, sodium, zlib - name: "Update dependencies with composer" uses: ramsey/composer-install@v3 @@ -72,8 +78,9 @@ jobs: uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php-version }} + extensions: ${{ env.PHP_EXTENSIONS }} + ini-values: ${{ env.PHP_INI_VALUES }} coverage: pcov - extensions: curl, fileinfo, intl, json, mbstring, simplexml, sodium, zlib - name: "Install dependencies with composer" uses: ramsey/composer-install@v3 @@ -106,10 +113,11 @@ jobs: - name: "Install PHP" uses: shivammathur/setup-php@v2 with: - php-version: "8.1" + php-version: "8.3" + extensions: ${{ env.PHP_EXTENSIONS }} + ini-values: ${{ env.PHP_INI_VALUES }} coverage: none tools: phpDocumentor - extensions: curl, fileinfo, intl, json, mbstring, simplexml, sodium, zlib - name: "Build API docs" run: phpdoc --config=phpdoc.xml.dist @@ -131,18 +139,9 @@ jobs: - name: "Checkout sources" uses: actions/checkout@v4 - - name: "Install PHP" - uses: shivammathur/setup-php@v2 - with: - php-version: "8.1" - coverage: none - - name: "Install Sphinx" run: pip install sphinx myst-parser sphinx-rtd-theme - - name: "Install dependencies with composer" - uses: ramsey/composer-install@v3 - - name: "Build manual" run: | cd docs