omit URI settings by default

Author: codemasher

src/AuthenticatorOptionsTrait.php

@@ -97,7 +97,7 @@ trait AuthenticatorOptionsTrait{
 	 *
 	 * @link https://github.com/google/google-authenticator/wiki/Key-Uri-Format#parameters
 	 */
-	protected bool $omitUriSettings = false;
+	protected bool $omitUriSettings = true;
 
 	/**
 	 * Sets the code length to either 6 or 8

tests/Authenticators/HOTPTest.php

@@ -64,9 +64,12 @@ public function HOTP(int $counter, string $hmac, int $code, string $hotp):void{
 
 	public static function uriSettingsProvider():array{
 		return [
-			'default' => [[], '&counter=42&digits=6&algorithm=SHA1'],
-			'digits'  => [['digits' => 8], '&counter=42&digits=8&algorithm=SHA1'],
-			'algo'    => [['algorithm' => AuthenticatorInterface::ALGO_SHA512], '&counter=42&digits=6&algorithm=SHA512'],
+			'default' => [['omitUriSettings' => false], '&counter=42&digits=6&algorithm=SHA1'],
+			'digits'  => [['omitUriSettings' => false, 'digits' => 8], '&counter=42&digits=8&algorithm=SHA1'],
+			'algo'    => [
+				['omitUriSettings' => false, 'algorithm' => AuthenticatorInterface::ALGO_SHA512],
+				'&counter=42&digits=6&algorithm=SHA512',
+			],
 			'omit'    => [['omitUriSettings' => true], '&counter=42'],
 		];
 	}

tests/Authenticators/TOTPTest.php

@@ -120,10 +120,13 @@ public function adjacent(string $algorithm, int $timestamp, string $timeslice, i
 
 	public static function uriSettingsProvider():array{
 		return [
-			'default' => [[], '&digits=6&algorithm=SHA1&period=30'],
-			'digits'  => [['digits' => 8], '&digits=8&algorithm=SHA1&period=30'],
-			'period'  => [['period' => 45], '&digits=6&algorithm=SHA1&period=45'],
-			'algo'    => [['algorithm' => AuthenticatorInterface::ALGO_SHA512], '&digits=6&algorithm=SHA512&period=30'],
+			'default' => [['omitUriSettings' => false], '&digits=6&algorithm=SHA1&period=30'],
+			'digits'  => [['omitUriSettings' => false, 'digits' => 8], '&digits=8&algorithm=SHA1&period=30'],
+			'period'  => [['omitUriSettings' => false, 'period' => 45], '&digits=6&algorithm=SHA1&period=45'],
+			'algo'    => [
+				['omitUriSettings' => false, 'algorithm' => AuthenticatorInterface::ALGO_SHA512],
+				'&digits=6&algorithm=SHA512&period=30',
+			],
 			'omit'    => [['omitUriSettings' => true], ''],
 		];
 	}