🚿

Author: codemasher

README.md

@@ -37,15 +37,15 @@ via terminal: `composer require chillerlan/php-authenticator`
 	}
 }
 ```
-Note: replace `dev-main` with a [version constraint](https://getcomposer.org/doc/articles/versions.md#writing-version-constraints), e.g. `^5.0` - see [releases](https://github.com/chillerlan/php-authenticator/releases) for valid versions
+Note: replace `dev-v5.x` with a [version constraint](https://getcomposer.org/doc/articles/versions.md#writing-version-constraints), e.g. `^5.0` - see [releases](https://github.com/chillerlan/php-authenticator/releases) for valid versions
 
 Profit!
 
 ## Usage
 ### Create a secret
 The secret is usually being created once during the activation process in a user control panel.
 So all you need to do there is to display it to the user in a convenient way -
-as a text string and QR code for example - and save it somewhere with the user data.
+as a text string and [QR code](https://github.com/chillerlan/php-qrcode/blob/9964cf8ff1ad90d17c360bd320cf18e16cd59829/examples/authenticator.php) for example - and save it somewhere with the user data.
 ```php
 use chillerlan\Authenticator\{Authenticator, AuthenticatorOptions};
 

src/AuthenticatorOptionsTrait.php

@@ -167,7 +167,7 @@ protected function set_adjacent(int $adjacent):void{
 	 * @throws \InvalidArgumentException
 	 */
 	protected function set_secret_length(int $secret_length):void{
-		// ~ 80 to 640 bits
+
 		if($secret_length < 16 || $secret_length > 1024){
 			throw new InvalidArgumentException('Invalid secret length: '.$secret_length);
 		}

src/Authenticators/HOTP.php

@@ -44,7 +44,9 @@ public function getHMAC(int $counter):string{
 		}
 		// @codeCoverageIgnoreStart
 		$data = (PHP_INT_SIZE < 8)
+			// 32-bit
 			? "\x00\x00\x00\x00".pack('N', $counter)
+			// 64-bit
 			: pack('J', $counter);
 		// @codeCoverageIgnoreEnd
 		return hash_hmac($this->options->algorithm, $data, $this->secret, true);
@@ -61,8 +63,8 @@ public function getCode(#[SensitiveParameter] string $hmac):int{
 		}
 
 		$b = ($data[strlen($hmac)] & 0xF);
-		// phpcs:ignore
-		return (($data[$b + 1] & 0x7F) << 24) | ($data[$b + 2] << 16) | ($data[$b + 3] << 8) | $data[$b + 4];
+
+		return (($data[$b + 1] & 0x7F) << 24) | ($data[$b + 2] << 16) | ($data[$b + 3] << 8) | $data[$b + 4]; // phpcs:ignore
 	}
 
 	/**