Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor 'view' object #2162

Open
hamed-musallam opened this issue Feb 17, 2023 · 0 comments · May be fixed by #2244
Open

refactor 'view' object #2162

hamed-musallam opened this issue Feb 17, 2023 · 0 comments · May be fixed by #2244
Assignees

Comments

@hamed-musallam
Copy link
Member

          > Ok, then we should have 3 objects

No, we should have everything inside of view:

view: {
  nuclei1D: { // Record<string, ViewNuclei1D>
    '1H': {},
    '13C': {},
  },
  nuclei2D: { // Record<string, ViewNuclei2D>
    '1H,1H': {},
  },
  spectra1D: { // Record<string, ViewSpectra1D>
    uuid1: {},
    uuid2: {},
  },
  spectra2D: { // Record<string, ViewSpectra2D>
    uuid3: {},
    uuid4: {},
  },
  prop1, // other settings that don't depend on nucleus or spectrum
  prop2,
}

Originally posted by @targos in #2135 (comment)

@hamed-musallam hamed-musallam self-assigned this Feb 17, 2023
@lpatiny lpatiny removed the priority label Feb 17, 2023
@hamed-musallam hamed-musallam linked a pull request Mar 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants