Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsZIP is slow #1967

Open
lpatiny opened this issue Nov 30, 2022 · 1 comment
Open

jsZIP is slow #1967

lpatiny opened this issue Nov 30, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@lpatiny
Copy link
Member

lpatiny commented Nov 30, 2022

The .nmrium file is compressed by default using ZIP (first bytes are PK)

This allows to win a lot of space, from 53.8 Mb to 21.3 Mb.

However this is also a super slow process ... Without compression it would take 2s and with compression it takes 20s !

image

We could try to compress the data using pako.gzip (anyway there is only one file so it could be as well gzip and not zipped).

Chrome also has a native API for compression: https://developer.mozilla.org/en-US/docs/Web/API/Compression_Streams_API and this could be tested as well.

@targos WDYT ?
@lpatiny lpatiny added the enhancement New feature or request label Nov 30, 2022
@lpatiny
Copy link
Member Author

lpatiny commented Dec 1, 2022

We should probably go towards gzip rather than zip for internal compression of .nmrium.

This should be managed likely be filelist-utils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
NMR and Cheminfo projects organisation
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lpatiny