Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid properties passed to update_meadata break chart #93

Open
robroc opened this issue Oct 26, 2021 · 2 comments
Open

Invalid properties passed to update_meadata break chart #93

robroc opened this issue Oct 26, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@robroc
Copy link

robroc commented Oct 26, 2021

🐛 Bug Report

Passing an invalid property to update_metadata is accepted and breaks the chart. Specifically, I passed

dw.update_metadata(dw_id, properties = {'annotate' : 'SAMPLE ANNONATION'})

instead of:

dw.update_metadata(dw_id, properties = {'annotate' : {'notes' : 'SAMPLE ANNONATION'}})

The update was accepted and the corresponding property appeared in chart_properties.

As a result, the chart in the web UI became unusable. In addition, the "Refine" tab on the website vanished.

I suggest adding to the docs a list of valid properties to pass, and offering error messages when invalid ones are passed.

Environment

  • OS: Windows
  • Python version: 3.8.10
  • DW version: 0.4.6
@robroc robroc added the bug Something isn't working label Oct 26, 2021
@github-actions
Copy link

Hello @robroc, thank you for your interest in our work!

If this is a bug report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

@chekos chekos self-assigned this Feb 2, 2022
@chekos
Copy link
Owner

chekos commented Feb 3, 2022

thank you for this! and the suggestion!

Apologies for the delay but I'll be working on updating datawrapper in the following weeks! I'm hoping to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants