[DO NOT MERGE] GHCP — Crawl: Ex15 Resilience and Failure Tests#125
Open
nikhil2611 wants to merge 1 commit into
Open
[DO NOT MERGE] GHCP — Crawl: Ex15 Resilience and Failure Tests#125nikhil2611 wants to merge 1 commit into
nikhil2611 wants to merge 1 commit into
Conversation
51e9d44 to
24f85fa
Compare
89dcb4a to
651368b
Compare
24f85fa to
4570af5
Compare
651368b to
a150c93
Compare
4570af5 to
7556832
Compare
a150c93 to
8d486de
Compare
7556832 to
f4f2bad
Compare
8d486de to
f16dbb2
Compare
f4f2bad to
9be9b26
Compare
Signed-off-by: nikhil2611 <ngupta@progress.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
f16dbb2 to
dcdcbc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added error-mapping rescue block to
knife status#runso HTTP 5xx and network failures produce a clear fatal message +exit 1instead of a raw stack trace. Added 2 failure tests proving both paths.Evidence
Failure tests:
when the Chef Server returns an HTTP error→ui.fatal+exit 1✅when the network is unreachable (SocketError)→ui.fatal+exit 1✅Review Focus
lib/chef/knife/status.rblines 76–90 —begin/rescueblock wrapping search; verify two rescue clausesspec/unit/knife/status_spec.rb—"resilience: error mapping"context (last 20 lines)ai-track-docs/resilience.md— documents failure modes, code location, and why error mapping over retryVerification Steps
Risk
Low — rescue clauses only trigger on exception; happy path is unchanged. Scoped to
knife status.Rollback