Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not tag release candidate as latest #1261

Open
clayrisser opened this issue Dec 14, 2018 · 4 comments
Open

Please do not tag release candidate as latest #1261

clayrisser opened this issue Dec 14, 2018 · 4 comments

Comments

@clayrisser
Copy link

1.0.0-rc.2 has bugs and should not be tagged as latest. Please tag it as next, and tag 0.22.0 as latest.

This issue is in response to #1260

@clayrisser clayrisser changed the title Please do not tag releace candidate as latest Please do not tag release candidate as latest Dec 14, 2018
@pgarciacamou
Copy link

I agree. Only stable releases should be tagged as latest. This tiny detail was breaking our new project when installing latest from npm.

@matthewmueller
Copy link
Member

matthewmueller commented Dec 27, 2018

Hey folks,

Apologies for the issues during this transition period. Parse5 will solve a lot of outstanding bugs since it behaves more like the browser, but it is a breaking change for sure.

We're going to continue to support htmlparser2 because there are lots of cases where the browser/Parse5's "tree correction" is not what you want or expect. If you prefer to use htmlparser2's parser you can do:

const dom = htmlparser2.parseDOM(file.contents, options)
const $ = cheerio.load(dom)

@astrotim
Copy link

Can anyone help with how to configure Enzyme to accept the htmlparser2: true option?

@0xdevalias
Copy link

0xdevalias commented Nov 28, 2019

@astrotim I opened an issue with enzyme about this as it seemed noone had yet: enzymejs/enzyme#2299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants