Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing UT changes to get possible property values #79

Open
Luolc opened this issue Aug 16, 2017 · 2 comments
Open

Processing UT changes to get possible property values #79

Luolc opened this issue Aug 16, 2017 · 2 comments

Comments

@Luolc
Copy link
Contributor

Luolc commented Aug 16, 2017

We could process the change of UT, find the changed method, and collect the property value from the config attribute.

Example PRs:
checkstyle/checkstyle#4905
checkstyle/checkstyle#4902
checkstyle/checkstyle#4853
checkstyle/checkstyle#4770
checkstyle/checkstyle#4736

We can assume the tests will be in a specific location as it should just be a change of main to test and appending Test to the class name.

@rnveach
Copy link
Member

rnveach commented Aug 16, 2017

process the change of UT, find the changed method

Like I said in google groups, We can't always expect there to be test changes with production code. If it is just a fixing of code and not a logic change or such, we still need to run regression on it and all it's properties to verify nothing changed or is broken.
Also why do we need to only grab the property values of changed UTs. If their values didn't change in regression, then it will agree with no changes in the UTs. If they show differences, than that is unexpected since they didn't make changes to those UTs and they should add them in their PR then. We should grab all values from UTs, and not just ones that changed.

I feel we will get better results if we grab all possible values in the Test and not just the ones that changed.
The only properties that probably may not produce any results will be regular expressions for file/folder paths.

@Luolc
Copy link
Contributor Author

Luolc commented Aug 16, 2017

Also why do we need to only grab the property values of changed UTs

I am OK with this. Whatever only changed UTs or all UTs, we would implement the same function that grab the property info. And I think grabbing from all UTs is good.

Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 21, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 24, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 24, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 28, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants