-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diff.groovy throws IllegalStateException on not english locale #334
Comments
The command is:
The output is:
appears on ru-Ru locale. |
This is because groovy executes another command inside of it (checkstyle/git) and it only passes specific parameters to the other commands. If you can help us with a fix, feel free to create a PR. |
When executing on another (not english) locale, diff.groove throws IllegalStateException with message:
Caught: java.lang.IllegalStateException: Error: git repository /home/kazachka/checkstyle has unstaged changes!
Exception is throwing from here:
https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/diff.groovy#L12
caused because localized git message doesn't contain english text "nothing to commit", so hasUnstagedChanges function returns true.
https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/diff.groovy#L156
The text was updated successfully, but these errors were encountered: