Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache core 5 support (Spring Boot 3) #369

Open
antoineriou opened this issue Oct 17, 2023 · 5 comments
Open

Apache core 5 support (Spring Boot 3) #369

antoineriou opened this issue Oct 17, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@antoineriou
Copy link

antoineriou commented Oct 17, 2023

Environment

  • Checkout SDK version: 6.0.19
  • Platform and version: Java SDK and Spring Boot App
  • Operating System and version: N/A

Description

We are migrating our app from spring boot 2.X to spring boot 3.X. A major change is the use of org.apache.hc.core5.http instead of org.apache.http.

In our app we are using the CheckoutSdk.builder() to instantiate a CheckoutApi Bean and we provide it a custom HttpClientBuilder which uses some custom Interceptors.

We are not able to find a way of using the new apache HttpClientBuilder with Checkout SDK. Is it possible to allow/implement the use of the new HttpClientBuilder from org.apache.hc.core5.http ?

Proposed Solution

N/A

@antoineriou antoineriou changed the title Spring Boot 3 and Apache core 5 support Apache core 5 support (Spring Boot 3) Oct 17, 2023
@armando-rodriguez-cko armando-rodriguez-cko self-assigned this Oct 17, 2023
@armando-rodriguez-cko armando-rodriguez-cko added the question Further information is requested label Oct 17, 2023
@armando-rodriguez-cko
Copy link
Contributor

Hello @antoineriou! We'll take a look and give you an answer soon. Thank you

@armando-rodriguez-cko armando-rodriguez-cko added the enhancement New feature or request label Jan 2, 2024
@armando-rodriguez-cko
Copy link
Contributor

Hi @antoineriou next month we will try to implement it.

@antoineriou
Copy link
Author

Hello @armando-rodriguez-cko, good news ! Thank you so much 🤝

@jzrebiec
Copy link

jzrebiec commented Sep 2, 2024

hello @armando-rodriguez-cko can you provide any update on this?

@armando-rodriguez-cko
Copy link
Contributor

Hi @jzrebiec and @antoineriou. We reprioritised the updates and implementations, so we didn’t have time to continue this change. However, it is still open, and we will try to resume work on it in the coming months, although we don’t have an ETA yet. Apologies for not updating this information here sooner. In any case, you have the opportunity to submit a PR to update the SDK with this proposal. Please feel free to do so, and I will be glad to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Development

No branches or pull requests

3 participants