Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result summary formatting #10

Open
aoxborrow opened this issue Aug 25, 2020 · 3 comments
Open

Result summary formatting #10

aoxborrow opened this issue Aug 25, 2020 · 3 comments

Comments

@aoxborrow
Copy link

Thanks for getting this to work on Windows! It's working well for us with a large PHPUnit suite.

I have two suggestions for the upper result summary part:

  • add some spacing between the X and the test name (see screenshot -- I'm on a Mac)
  • add the line number of assertion failure next to the method name. This would mean we don't have to scroll down into the many failures below to find the line that failed, and the summary becomes more useful.

Screen Shot 2020-08-25 at 1 55 51 PM copy

@ianwremmel
Copy link
Collaborator

Oh, good call. I'm right in the middle of some other changes (backoffice stuff), but I ought to be able to get that out in a few days.

@ianwremmel
Copy link
Collaborator

the line number thing is actually a bit more complicated. Tests are organized by their name which may be a filename, but doesn't have to be. A line number could be a bit out of place without also including a filename, but including a filename for each line item will burn a lot of characters (github has a surprisingly low limit on how much data can be sent there).

I've got a few ideas I'll noodle on. Will probably have something out early next week.

@ianwremmel
Copy link
Collaborator

I'm in the midst of releasing a version that should add line numbers to the top half. Eventually, I'd like to make each test failure that can be traced to a file a link to that file, but hopefully this is a start that'll make things a little easier for you.

@ianwremmel ianwremmel reopened this Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants