Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy _app.tsx and _document.tsx within the Root Layout #1040

Open
boodland opened this issue Jul 18, 2024 · 4 comments
Open

Copy _app.tsx and _document.tsx within the Root Layout #1040

boodland opened this issue Jul 18, 2024 · 4 comments
Assignees
Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days feature/enhancement New feature or request maintenance Maintenance / chore work
Milestone

Comments

@boodland
Copy link
Contributor

boodland commented Jul 18, 2024

Sub issue of #702

App router uses a Root layout which is defined at the top of the app directory and applies to all routes. We need to copy/migrate the contents of _app.tsx and _document.tsx to the root layout so they are applied for the app route.

This issue also migrate meet-the-team page in order to check that the new app route logic works as expected

@boodland
Copy link
Contributor Author

@kyleecodes, @eleanorreem assign it to me please

Copy link
Contributor

Thank you @boodland you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨


Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn here and explore our projects. 🌸

@boodland
Copy link
Contributor Author

@eleanorreem created pull request of the issue, it has been much more challenged that I expected due to all the moving pieces involved, lets start a discussion either in the pull request or slack to clarify you the issues that have motivated the implementation and tell me better ways to solve it

I won't be available next week as I will be off

Copy link
Contributor

As per Chayn policy, after 30 days of inactivity, we will be unassigning this issue. Please comment to stay assigned.

@github-actions github-actions bot added the stale This issue or PR is inactive label Sep 16, 2024
@kyleecodes kyleecodes removed the stale This issue or PR is inactive label Sep 17, 2024
@github-actions github-actions bot added the stale This issue or PR is inactive label Oct 21, 2024
@kyleecodes kyleecodes removed the stale This issue or PR is inactive label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days feature/enhancement New feature or request maintenance Maintenance / chore work
Projects
Development

No branches or pull requests

2 participants