chore: optimize output of install script, remove bin if present

Signed-off-by: Charlie Chiang <[email protected]>

hack/install.sh

@@ -9,35 +9,83 @@ if ! command -v curl >/dev/null; then
   exit 1
 fi
 
+confirm() {
+  while true; do
+    echo -n "$1 [y/n]: "
+    read -r -n 1 REPLY
+    case $REPLY in
+    [y])
+      echo
+      return 0
+      ;;
+    [n])
+      echo
+      return 1
+      ;;
+    [Y])
+      echo
+      return 0
+      ;;
+    [N])
+      echo
+      return 1
+      ;;
+    *) printf "invalid input" ;;
+    esac
+  done
+}
+
+info() {
+    echo -e "$(date +'%Y-%m-%d %H:%M:%S') \033[34m[INFO]\033[0m $*"
+}
+
 launch_daemon="/Library/LaunchDaemons/cc.chlc.batt.plist"
 
 # Uninstall old versions (if present)
 if [[ -f "$launch_daemon" ]]; then
-  echo "Removing old version of batt..."
+  info "Stopping old versions of batt..."
   sudo launchctl unload "$launch_daemon"
   sudo rm -f "$launch_daemon"
+  old_batt_bin="$(which batt || true)"
+  if [[ -f "$old_batt_bin" ]]; then
+    info "Removing old versions of batt..."
+    sudo rm -f "$old_batt_bin"
+  fi
 fi
 
 tarball_suffix="darwin-arm64.tar.gz"
 
-echo -n "Querying latest batt release..."
+info "Querying latest batt release..."
 # jq is intentionally not used here because it is not available on macOS by default
 res=$(curl -fsSL https://api.github.com/repos/charlie0129/batt/releases/latest)
 tarball_url=$(echo "$res" |
   grep -o "browser_download_url.*$tarball_suffix" |
   grep -o "https.*")
 version=$(echo "$res" | grep -o "tag_name.*" | grep -o "\"v.*\"")
-echo " $version"
+version=${version//\"/}
+info "Latest stable version is ${version}."
 
 if [[ -z "$PREFIX" ]]; then
   PREFIX="/usr/local/bin"
 fi
 
-echo "Downloading batt from $tarball_url to $PREFIX (to change install location, set \$PREFIX env)"
+echo "Will install batt ${version} to $PREFIX (to change install location, set \$PREFIX environment variable)."
+confirm "Continue?" || exit 0
+info "Downloading batt ${version} from $tarball_url and installing to $PREFIX..."
 sudo mkdir -p "$PREFIX"
-curl -L "$tarball_url" | sudo tar -xzC "$PREFIX"
+curl -fsSL "$tarball_url" | sudo tar -xzC "$PREFIX"
 
 install_cmd="sudo $PREFIX/batt install --allow-non-root-access"
-echo "Installing batt..."
+info "Installing batt..."
 echo "- $install_cmd"
 $install_cmd
+
+info "Installation finished."
+echo "Further instructions:"
+echo '- If you see an alert says "batt cannot be opened because XXX", please go to System Preferences -> Security & Privacy -> General -> Open Anyway.'
+echo "- Be sure to **disable** macOS's optimized charging: Go to System Preferences -> Battery -> uncheck Optimized battery charging."
+echo '- To set charge limit to 80%, run "batt limit 80".'
+echo '- To see batt help: run "batt help".'
+echo '- To see disable charge limit: run "batt limit 100".'
+echo '- To uninstall: run "sudo batt uninstall" and follow the instructions.'
+echo '- To upgrade: just run this script again when a new version is released.'