fix deployment search bug

Author: charleyw

app-packer.js

@@ -24,7 +24,9 @@ class AppPacker {
           version: crypto.createHash('sha256').update(JSON.stringify(Object.keys(fileHashes).map(k => `${k}:${fileHashes[k]}`, []).sort())).digest('hex')
         };
         resolve(manifest)
-      })
+      });
+
+      walker.on('error', err => reject(err))
     })
   }
 

models/deployment.js

@@ -7,7 +7,7 @@ class Deployment extends AV.Object {
   static byAppNameAndUserId(name, userId) {
     const innerQuery = new AV.Query(App);
     innerQuery.equalTo('name', name);
-    innerQuery.equalTo('user', User.createWithoutData(userId));
+    innerQuery.matchesQuery('user', AV.Object.createWithoutData('User', userId));
     const query = new AV.Query(Deployment);
     query.matchesQuery('app', innerQuery);
 
@@ -17,7 +17,7 @@ class Deployment extends AV.Object {
   static findBy(appName, deploymentName, userId) {
     const innerQuery = new AV.Query(App);
     innerQuery.equalTo('name', appName);
-    innerQuery.equalTo('user', User.createWithoutData(userId));
+    innerQuery.matchesQuery('user', AV.Object.createWithoutData('User', userId));
     const query = new AV.Query(Deployment);
     query.matchesQuery('app', innerQuery);
     query.equalTo('name', deploymentName);

routes/deployments.js

@@ -43,7 +43,8 @@ router.get('/', function (req, res, next) {
 const unzipPackage = (zipFilePath, zipName) => new Promise((resolve, reject) => {
   const localPackagePath = `${os.tmpdir()}/${zipName}.unzipped`;
   fs.createReadStream(zipFilePath).pipe(unzip.Extract({path: localPackagePath}))
-    .on('close', () => resolve({baseDir: localPackagePath, originalFilePath: zipFilePath, originalFileName: zipName}));
+    .on('close', () => resolve({baseDir: localPackagePath, originalFilePath: zipFilePath, originalFileName: zipName}))
+    .on('error', reject);
 });
 
 const generateManifest = options => new Promise((resolve, reject) => {
@@ -67,7 +68,7 @@ const deploymentFullPackage = (packageInfo, deployment, user) => options => new
       resolve(Object.assign({}, options, {packageInfo, fullPackage: savedFullPackage}))
     ).catch(err => console.log('error: ', err));
   }).catch(err => {
-    throw err;
+    reject(err);
   })
 });
 
@@ -78,11 +79,15 @@ router.post('/:deploymentName/release', multipartMiddleware, function (req, res,
         unzipPackage(req.files.package.path, req.files.package.name)
           .then(generateManifest)
           .then(deploymentFullPackage(JSON.parse(req.body.packageInfo), deployments[0], AV.Object.createWithoutData('User', req.user.id)))
-          .then(result => res.json({ok: true}))
+          .then(result => res.json({ok: true})).catch(err => {
+            throw err
+        })
       } else {
         res.json({error: 'no deployment found'})
       }
-    });
+    }).catch(err => {
+      throw err;
+  });
 });
 
 router.get('/:depoymentName/metrics', function (req, res, next) {