From be80d9b2ada951e7b7e807d810df0ef9f9dea7b5 Mon Sep 17 00:00:00 2001 From: Samyak S Sarnayak Date: Mon, 17 Jan 2022 19:11:21 +0530 Subject: [PATCH] fix: only log error when anomaly needs to run `anomaly_task` will be None when anomaly doesn't need to run. We will still log an error in that case, when there's actually no error. Co-authored-by: Kartikay Bagla --- chaos_genius/jobs/anomaly_tasks.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/chaos_genius/jobs/anomaly_tasks.py b/chaos_genius/jobs/anomaly_tasks.py index 8f4223983..bbc1f83c5 100644 --- a/chaos_genius/jobs/anomaly_tasks.py +++ b/chaos_genius/jobs/anomaly_tasks.py @@ -319,11 +319,12 @@ def queue_kpi_analytics(kpi_id: int, run_anomaly=True): else: rca_task.apply_async() - if anomaly_task is None: - logger.error( - "Not running anomaly since it is not configured or KPI " - "(%d) was not found.", - kpi_id, - ) - else: - anomaly_task.apply_async() + if run_anomaly: + if anomaly_task is None: + logger.error( + "Not running anomaly since it is not configured or KPI " + "(%d) was not found.", + kpi_id, + ) + else: + anomaly_task.apply_async()