Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if connected to SQL Azure and warn user that platform is not supported. #1

Open
HannahVernon opened this issue May 21, 2021 · 2 comments

Comments

@HannahVernon
Copy link

Checking if the connected instance is SQL Azure via the following code, which returns 1 if the instance is Azure SQL Database, should exit the module with advice that SQL Azure is not supported:

SELECT CASE WHEN CONVERT(nvarchar(128), SERVERPROPERTY(N'Edition')) LIKE N'%Azure%' THEN 1 ELSE 0 END
@m82labs
Copy link
Contributor

m82labs commented Jun 12, 2021

🤔 do you have any ideas on adding this support? I do not use Azure so I am not sure what kinds of differences might prevent sqltop from working.

@lowlydba
Copy link
Contributor

Since Azure updates quietly pretty often, I think the only real way to handle support is to automate testing against it consistently (on PRs or even more often than that). I use appveyor for a project to test on Azure + lots of versions but the Azure piece is a constant PITA and if you don't already have something setup, I'd say it may not be worth it just for that.

A "your mileage may vary" approach might be the easiest, or block it altogether like Hannah suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants