Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable packages through testmempoolaccept #284

Open
azuchi opened this issue Oct 12, 2023 · 1 comment
Open

Enable packages through testmempoolaccept #284

azuchi opened this issue Oct 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@azuchi
Copy link
Contributor

azuchi commented Oct 12, 2023

Similar to Bitcoin, multiple parent-child transactions can be tested using testmempoolaccept RPC.

@azuchi azuchi added the enhancement New feature or request label Oct 12, 2023
@Naviabheeman
Copy link
Contributor

Naviabheeman commented Jan 21, 2024

#292 contains both testmempoolaccept and submitpackage RPCs.

  1. The PR toes not change fee related behaviour. In bitcoin Package transactions are evaluated as one whole entity while checking for fee. A parent transaction can pay the fee of a child. in tapyrus fee id still paid by individual transactions. We need to decide whether to change this and which transaction pays for the package fee: Any one tx in the package/ first/ parent tx / all tx.

  2. Package transportation is not implemented in bitcoin, each transaction is relayed individually. We can implement relay if necessary - add a package header similar to block header. Allow package relay only in well defined cases - for example peers which have dos score 0. The difference between block and package will be that package txs are unconfirmed and are added to mempool as a whole or nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants