Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure models are updated in fast tests of agents #403

Open
muupan opened this issue Feb 24, 2019 · 0 comments
Open

Make sure models are updated in fast tests of agents #403

muupan opened this issue Feb 24, 2019 · 0 comments

Comments

@muupan
Copy link
Member

muupan commented Feb 24, 2019

There are two types of tests for agents: fast tests and slow tests. In fast tests, an agent is trained on an env for a small amount of steps. Slow tests continues until the agent solves the env.

The purpose of fast tests is to quickly check if code runs without error. However, it seems that in some agents' fast tests code that updates models is not executed due to too small amout of training steps, resulting in overlooked bugs like #399 #400 #402 . I think it is better to make sure that the update code is executed for each agent in its fast tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant