Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary chopping #141

Open
notestaff opened this issue Aug 23, 2024 · 0 comments
Open

unnecessary chopping #141

notestaff opened this issue Aug 23, 2024 · 0 comments

Comments

@notestaff
Copy link

notestaff commented Aug 23, 2024

At

end_hits = [iv for iv in self.at(end) if iv.end > end]

should this be
end_hits = [iv for iv in self.at(end) if iv.begin < end]

? The end of the chopping interval is not part of the chopping interval, and an existing interval that starts at the end of the chopping interval does not need any part of it chopped off. Also, checking iv.end > end seems unnecessary since it should hold for any interval returned by self.at(end).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant