Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: resolvedWith #256

Open
mm-gmbd opened this issue Jul 3, 2019 · 2 comments
Open

Feature request: resolvedWith #256

mm-gmbd opened this issue Jul 3, 2019 · 2 comments

Comments

@mm-gmbd
Copy link

mm-gmbd commented Jul 3, 2019

There may be a great reason to not include this, but it feels a bit odd (as I'm starting to write some async test cases) to provide a rejectedWith but not a fulfilledWith.

I understand that I can use .to.eventually.be.fulfilled.and.equal, but I'm wondering -- are:

  • .to.eventually.be.rejected.and.equal(), and
  • .to.eventually.be.rejectedWith()

not essentially the same?

If so, I'd think that the fulfilledWith "shortcut" should also be included. If they're not the same, then we can close this request due to my ignorance 😄

@e22m4u
Copy link

e22m4u commented Sep 3, 2024

Same here. I was surprised by the lack of "resolvedWith" and "fulfilledWith". But I think the problem is in how we’re should compare a Promise result with the expectation - eq vs eql

expect(promise).to.eventually.be.eq(expectation);
expect(promise).to.eventually.be.eql(expectation);

@43081j
Copy link
Contributor

43081j commented Sep 7, 2024

seems like a sensible idea to have fulfilledWith. it'd be pretty simple I think compared to rejectedWith since rejectedWith supports passing errors, error constructors, etc. meanwhile, fulfilledWith would literally do the same as an equality check

if either of you want to contribute that, i'd be happy to review

otherwise I can try find time to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants