Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataDog 2.5.0 fails to build #790

Closed
jpsim opened this issue Dec 7, 2023 · 2 comments
Closed

DataDog 2.5.0 fails to build #790

jpsim opened this issue Dec 7, 2023 · 2 comments
Assignees
Labels
bug Something isn't working need more info Waiting for a response from the issue author or third-party.

Comments

@jpsim
Copy link
Collaborator

jpsim commented Dec 7, 2023

Released here: https://github.com/DataDog/dd-sdk-ios/releases/tag/2.5.0

external/rules_swift_package_manager~override~swift_deps~swiftpkg_dd_sdk_ios/DatadogTrace/Sources/TraceConfiguration.swift:15:24: error: enum 'URLSessionInstrumentation' does not exist in module 'DatadogInternal'
@_exported import enum DatadogInternal.URLSessionInstrumentation
                       ^               ~~~~~~~~~~~~~~~~~~~~~~~~~
external/rules_swift_package_manager~override~swift_deps~swiftpkg_dd_sdk_ios/DatadogTrace/Sources/Integrations/TracingURLSessionHandler.swift:56:84: error: extra argument 'tracestate' in call
                writer = W3CHTTPHeadersWriter(sampler: tracingSampler, tracestate: [:])
                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
external/rules_swift_package_manager~override~swift_deps~swiftpkg_dd_sdk_ios/DatadogTrace/Sources/TraceConfiguration.swift:15:24: error: enum 'URLSessionInstrumentation' does not exist in module 'DatadogInternal'
@_exported import enum DatadogInternal.URLSessionInstrumentation
                       ^               ~~~~~~~~~~~~~~~~~~~~~~~~~

2.4.0 builds fine.

@cgrindel cgrindel added the bug Something isn't working label Dec 9, 2023
@cgrindel cgrindel self-assigned this Dec 9, 2023
@cgrindel cgrindel added the need more info Waiting for a response from the issue author or third-party. label Dec 9, 2023
@cgrindel
Copy link
Owner

cgrindel commented Dec 9, 2023

Created #797 to try and reproduce the issue. I added DataDog 2.5.0 to the resources_example. The compilation works. Perhaps there is another module that is being referenced in the client's workspace. I have asked @jpsim to check #797 locally. Also, it might be useful to get a list of the imports that are being used from the DataDog package.

@jpsim
Copy link
Collaborator Author

jpsim commented Dec 21, 2023

I’m not seeing this issue any more. Not sure what it was originally. Sorry for never providing more info.

@jpsim jpsim closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need more info Waiting for a response from the issue author or third-party.
Projects
None yet
Development

No branches or pull requests

2 participants