Blank texture in gg.visualization.drape_array_over_dem (+ default zmax)

[spasquet]

Hi there,

I want to report an issue with gg.visualization.drape_array_over_dem that I managed to solve.
I was getting a texture filled with an array of ones, associated with a warning from pv.numpy_to_texture telling me my array was not in uint8.

It turns out that skimage.transform.resize was changing the format of the array (scikit-image 0.21.0 installed)
Adding option preserve_range=True to the skimage.transform.resize function solved it :

if resize_array:
            array = resize(image=array,
                           preserve_range=True,
                           output_shape=(dem.shape[0],
                                         dem.shape[1]))
        else:
            dem = resize(image=dem,
                         preserve_range=True,
                         output_shape=(array.shape[0],
                                       array.shape[1]))

Also, could you please change the default zmax in gg.visualization.drape_array_over_dem ?
It is now set to 1000...I was working with data in the Alps at 2500m and it took me forever to figure out why the draping wasn't functioning. There should only be a valid zmax when specifically mentioned. I have now set it to 10000 by default now, it does the trick.

Best
Sylvain

[github-actions]

Hello and welcome! Thanks for posting your first issue in the GemGIS project! Someone from our developers will get back to you. If your question is support related, we may transfer it to the Discussions.

[AlexanderJuestel]

@spasquet Thank you for the raising this issue, I will have a look at it tomorrow first thing and it will be fixed in the next release! Otherwise, you could open a PR and implement the changes :)

[AlexanderJuestel]

Your fix was implemented in bfbd01e. However, as we are changing the way we deploy the package to pypi, you can only download the Github repo to get the latest features. Sorry for this inconvenience

[spasquet]

Great thanks !

[AlexanderJuestel]

@spasquet I have released GemGIS 1.1.3 yesterday. You may want to check it out :)