feat: improve signup form UX #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent accidental commits of fork management documentation: - FORK_MANAGEMENT.md (fork strategy and custom features) - CLAUDE.md (project context for Claude Code) - SESSION.md (session state tracking) - BRANCH_README.md (branch-specific notes) - JEZWEB_SETUP.md (local setup notes) - docs/FUTURE_FEATURE_IDEAS.md - docs/MCP_CREDENTIAL_SECURITY.md - docs/MCP_CREDENTIAL_SECURITY_ISSUE.md - docs/features/ These files contain fork-specific context and should not be pushed to the repository. Generated with Claude Code (https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Increases password length from 20 to 128 characters to support
passphrases and align with NIST recommendations. Database already
supports unlimited length (text type), so no migration needed.
Changes:
- Update regex pattern from {8,20} to {8,128}
- Update requirements text to reflect new range
- Update Zod max validation to 128 characters
Changes: - Change "Full Name" to "Name" for clearer, more concise label - Remove "Cgoing" placeholder (was confusing/looked like typo) Improves user experience by removing unnecessary words and potentially confusing example text.
Adds a confirm password field to the signup form with real-time visual feedback to improve user experience and prevent typos. Changes: - Add confirmPassword to form state - Import Check and X icons from lucide-react - Add validation check in successPasswordStep before Zod validation - Add second password field with real-time visual indicators: - Green checkmark icon when passwords match - Red X icon when passwords don't match - Green/red border colors on confirm field - Icons only show when confirmPassword has content - Separate password fields into gap-4 container for better spacing User experience improvements: - Immediate feedback prevents submission errors - Clear visual indicators (icons + border colors) - Toast error if user tries to submit with mismatched passwords
Adds translations for new password confirmation field and error message across all 6 supported languages. New translation keys: - confirmPassword: Label for password confirmation field - passwordsDoNotMatch: Error when passwords don't match Languages updated: - English (en) - Korean (ko) - French (fr) - Japanese (ja) - Spanish (es) - Chinese (zh)
|
Someone is attempting to deploy a commit to the cgoinglove's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the signup form with three key user experience improvements:
1. Increased Password Length Limit (20 → 128 characters)
texttype, so no migration needed2. Simplified Labels & Removed Example Placeholder
3. Password Confirmation with Real-time Validation
Translation Support
All 6 supported languages updated:
New translation keys:
confirmPassword: Label for confirmation fieldpasswordsDoNotMatch: Error messageFiles Changed
src/lib/validations/password.ts- Password length limitssrc/components/auth/email-sign-up.tsx- UI and validation logicmessages/*.json- All 6 translation filesTesting
Screenshots
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]