Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo is not working with F-droid Basic 1.19.0-alpha0 #11

Closed
realAllonZ opened this issue Oct 29, 2023 · 12 comments
Closed

Repo is not working with F-droid Basic 1.19.0-alpha0 #11

realAllonZ opened this issue Oct 29, 2023 · 12 comments
Assignees

Comments

@realAllonZ
Copy link

I am no longer able to connect with the c:geo F-droid repo:

https://fdroid.cgeo.org/?fingerprint=370bb4d550c391d5dccb6c81fd82fda4892964764e085a09b7e075e9bad5ed98

Please say it ain't so!

@kumy
Copy link
Member

kumy commented Oct 29, 2023

I got an update this morning. It should be up. I'll double check tomorow.

@kumy
Copy link
Member

kumy commented Oct 29, 2023

Seems working fine for me.

@realAllonZ
Copy link
Author

I see that the repo is working correctly with F-droid. However, it is not working for me using F-droid basic. See the screenshots bellow for confirmation:

Screenshot1_F-Droid Basic

Screenshot2_F-Droid Basic

@kumy
Copy link
Member

kumy commented Oct 30, 2023

I installed and tested fdeoid basic. It's also working here. But I don't have the same the same UI as you. What is your fdroid basic version ? I have 1.18.0

Screenshot_20231030-073843.png

Screenshot_20231030-073835.png

Screenshot_20231030-073831.png

Screenshot_20231030-073903.png

Screenshot_20231030-074142.png

@kumy kumy changed the title Is the F-droid repo no longer being maintained? Repo is not working with F-Droid basic Oct 30, 2023
@realAllonZ
Copy link
Author

I was on F-droid Basic 1.19.0-alpha0 and when I downgraded to 1.18.0 the repo was added successfully.

Thanks for helping me track down the issue @kumy

@realAllonZ realAllonZ changed the title Repo is not working with F-Droid basic Repo is not working with F-droid Basic 1.19.0-alpha0 Oct 30, 2023
@realAllonZ
Copy link
Author

I was about to post about this issue on New Issue · F-Droid / Client · GitLab, but while gathering more screenshots I realized that your repo was the only one that was not working with Basic Alpha.

I also tried adding the repo on F-Droid 1.18.0 and F-Droid 1.19.0-alpha0, several times, with relatively similar results. Though the 1st time Alpha did recognized the repo and subsequent attempts on Alpha revealed the Invalid Repo org.fdroid.download.NotFoundException

With this new information, it is possible that the issue may be with the c:geo repo after all.

I will wait for your response before posting the issue to F-Droid on GitLab.

@realAllonZ realAllonZ reopened this Oct 30, 2023
@kumy
Copy link
Member

kumy commented Oct 30, 2023

I also think something needs to be updated on our side. Now that I know how to reproduce I will have a second look at the issue :)

kumy added a commit that referenced this issue Oct 30, 2023
The new version tries to find the files under a new structure.
Our config need update, but in the meantime let's put a simple fix for
the issue.

Relates #11
@kumy
Copy link
Member

kumy commented Oct 30, 2023

I've pushed a new commit to the repo, updating the nginx config. @realAllonZ Please test again 🙏

I've found that when adding the repository, F-Droid Basic 1.19.0-alpha0 look for the index files in the folder /fdroid/repo instead of / as we used to. Once the repo is added, all subsequent HEAD/GET are done to the old know urls.

Not sure if it's a bug or not 🤷

# Adding the repo for the first time. The indexes a searched in the `/fdroid/repo` instead of `/`
 xxx - - [30/Oct/2023:18:31:41 +0000] "GET /fdroid/repo/entry.jar HTTP/1.1" 404 153 "-" "F-Droid 1.19.0-alpha0"
 xxx - - [30/Oct/2023:18:31:41 +0000] "HEAD /fdroid/repo/index-v1.jar HTTP/1.1" 200 0 "-" "F-Droid 1.19.0-alpha0"
 xxx - - [30/Oct/2023:18:31:42 +0000] "GET /fdroid/repo/index-v1.jar HTTP/1.1" 200 5349 "-" "F-Droid 1.19.0-alpha0"

# just after adding, there is a confirmation step. Once validated, new requests are done on plain old known url
 xxx - - [30/Oct/2023:18:31:51 +0000] "HEAD /entry.jar HTTP/1.1" 404 0 "-" "F-Droid 1.19.0-alpha0"
 xxx - - [30/Oct/2023:18:31:51 +0000] "HEAD /index-v1.jar HTTP/1.1" 200 0 "-" "F-Droid 1.19.0-alpha0"
 xxx - - [30/Oct/2023:18:31:51 +0000] "GET /index-v1.jar HTTP/1.1" 200 5349 "-" "F-Droid 1.19.0-alpha0"

# Then subsequent enable/disable/reload of the repositories use the old known url
 xxx - - [30/Oct/2023:18:32:03 +0000] "HEAD /entry.jar HTTP/1.1" 404 0 "-" "F-Droid 1.19.0-alpha0"
 xxx - - [30/Oct/2023:18:32:03 +0000] "HEAD /index-v1.jar HTTP/1.1" 200 0 "-" "F-Droid 1.19.0-alpha0"

@realAllonZ
Copy link
Author

The c:geo repo is now being recognized by F-droid Basic 1.19.0-alpha

Thanks @kumy

Shall I post the possible bug to New Issue · F-Droid / Client · GitLab ?

@kumy
Copy link
Member

kumy commented Oct 30, 2023

Shall I post the possible bug to New Issue · F-Droid / Client · GitLab ?

As you wish 🤷, but I would be interested to know if it's a feature or a bug...

@kumy
Copy link
Member

kumy commented Oct 30, 2023

https://gitlab.com/fdroid/fdroidserver/-/blob/master/examples/config.yml#L51-53
The issue seems to be our old version of the server.

@kumy
Copy link
Member

kumy commented Oct 30, 2023

Created #12 for the upgrade task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants