-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to elasticsearch with heatmap support #230
Comments
@JorgeMartinezG to fix tests you will first have to uncomment them. I believe @panchicore commented them all I but I am not sure why. |
Travis tests won't pass because this version of elasticsearch has permission issues when the docker image is run on Linux environments. I tested in Ubuntu 16.04 with this ouput.
Checking in the forums....they recommend to grant permissions. Any thoughts? @ingenieroariel @sstults |
Can you run the tests with the official 5.0.0 image [0] and then use that Dockerfile as the basis for this one? [1] [0] https://github.com/docker-library/elasticsearch/blob/master/5.0/Dockerfile |
It's a good idea. However, that elasticsearch version won't have the gridlevel support, because the current dockerfile pulls from this repo: |
Right - what I mean is building that elastic search exactly like the official one. Or using the official one and then just replacing the artifacts with ones compiled from the branch |
Virtual memory map area in Linux, comes with a small value. This causes elasticsearch to stop execution on its container, making travis fail. Fix is already sent in PR with tests passed |
Heatmap test is failing executing one assertion. The test was created to assert if a returning value is None. However, in solr, the returned value is an empty list. For elasticsearch, is a list of empty lists. https://github.com/cga-harvard/HHypermap/blob/issue_230/hypermap/search_api/tests.py#L346 |
ES_JAVA_OPTS="-Xms512m -Xmx512m" ./elasticsearch/bin Solves the problem for me |
@JorgeMartinezG @ingenieroariel can this be closed? |
The text was updated successfully, but these errors were encountered: