-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent request storage Access behavior #4
Comments
Hi @jagadeeshaby, thanks for testing this out!
Without more information about the cases you've found, it's hard to say whether it's a bug or not, but there are some cases when
If you are testing in Chrome Canary, you may also be seeing some new work done by one of my colleagues. There is a proposed change to the specification such that
Can you give any more information about the behavior you're seeing, and how to reproduce this? In particular:
I'm not aware of any bugs in the API at the moment, but am happy to debug this with you. CC @shuranhuang |
Hi @cfredric, I have a similar question. I've been testing on Chrome Version 115.0.5790.114 and my set up is the following:
Flags I'm using:
I realized that even though I clicked "block" in the Chrome prompt, the subsequent |
Hi @andywang219, yes, that is the expected result. Please see the specification here, particularly the note under the "permission query algorithm":
You (the user) should still be able to see the "blocked" status in the permissions UI on |
Thank you! |
I'm struggling with testing the API end to end: Here is what i observe on chrome canary so far. Example setup is as follows:
and browser setting is as follows: 2 flags tied to storage partition is on (prompt and UI) Scenario 1:
Scenario 2 if i would go ahead and explicitly allow access to third party cookies by clicking on "site not working" prompt on the URL bar then everything works this time, this is same as allowing third party cookies so i don't think i should be doing this So i'm stuck on identifying what should be the default cookie settings within privacy and security for testing, at present i have like below and with this i couldn't get the request storage access working for me.
Could you clarify around what should be the default cookie settings when chrome releases request storage feature and after third party cookie deprecation, and is it expected to have the "Block third-party cookies" settings enabled and then make use of RSA query to gain access to those cookies, if yes do you do know why isn't it not working? Also while testing locally does localhost endpoint makes any difference for this behavior? |
Hi @jagadeeshaby - thanks for continuing to test this out.
Just to confirm - are you referring to the
If I understand correctly, you're requesting storage access from one embedded page, which then redirects to a different page (that tries to actually use the storage access)? The reason I ask is that by default*, every frame that wants access to unpartitioned cookies must ask for it, even if some other frame has already requested and obtained the same access. I.e., the embedded SaaS app needs to call *With that said, there are some situations in which a frame that obtains storage access and then navigates somewhere else is allowed to keep the storage access, without having to call
Confirmed that blocking third-party cookies and then using
I'm not aware of anything that would cause an issue when using localhost. As long as you're able to call |
thank you, that makes complete sense to me
this is where i'm struggling , below is the code snippet used for testing, where i start with hasStorageAccess method and then invoke requestStorageAccess once and show the access button if no access and then proceed with click action. This code is executes within the embedded rsa page.
No, it's like first get access, and then open login popup which runs on the same domain as the embedded page which sets the cookie and auto close. and embedded page is the one which uses those cookies set in the popup. note cookie is set using the same domain which gets embedded as well ( same site) I would expect that once rsa is granted within the embedded context , cookies set on the embedded domain should be made available, but it doesn't work. |
Okay here is what i found, seems like the implementation with storage APIs works perfectly fine as soon as move to https enabled endpoint ( spec says the same as well) . I had to test this out on our Integ environment and everything works just fine. May be it's worth highlighting that for local testing make sure to have https enabled. |
Great, glad to hear that! I've added a note about the security requirements to the testing instructions section (49ed2b8). Since it sounds like you've found the source of the problem, I'm going to close this issue. |
While testing the RSA implementation we found that in few cases
permissions.query
would result in Prompt output, howeverdocument.hasStorageAccess()
results in true. Not sure what's causing it though.Are there any known bugs/issues among
hasStorageAccess
v/snavigator.permissions.query
?Also another scenario observed is, even after making an explicit rsa call, the permissions goes into denied mode (
DOMException: requestStorageAccess not allowed
) , not sure how to get this working again. We are using an explicit button click action to request the permission. Tried clearing the site data and other info nothing worked.The text was updated successfully, but these errors were encountered: