From 8618a96567b665fe8c86e870ab9cd95b1602d5b8 Mon Sep 17 00:00:00 2001
From: shindigira <shindigira@gmail.com>
Date: Wed, 29 May 2024 09:50:24 -0700
Subject: [PATCH 1/8] content(Complete User Profile): Updated the language,
 commented out button

---
 .../AddFinancialInstitution.tsx               |  8 ++++++-
 .../ProfileForm/CreateProfileForm/index.tsx   | 21 ++++++++++++-------
 2 files changed, 20 insertions(+), 9 deletions(-)

diff --git a/src/pages/ProfileForm/CreateProfileForm/AddFinancialInstitution.tsx b/src/pages/ProfileForm/CreateProfileForm/AddFinancialInstitution.tsx
index 03e07f733..ce12aeaad 100644
--- a/src/pages/ProfileForm/CreateProfileForm/AddFinancialInstitution.tsx
+++ b/src/pages/ProfileForm/CreateProfileForm/AddFinancialInstitution.tsx
@@ -9,15 +9,17 @@ interface AddFinancialInstitutionProperties {
   index: number;
   register: UseFormRegister<ValidationSchemaCPF>;
   formErrors: FieldErrors<ValidationSchemaCPF>;
+  isLast?: boolean;
 }
 
 function AddFinancialInstitution({
   index,
   register,
   formErrors,
+  isLast,
 }: AddFinancialInstitutionProperties): JSX.Element {
   return (
-    <div className='mb-[1.875rem]' key={index}>
+    <div className={isLast ? '' : 'mb-[1.875rem]'} key={index}>
       <FieldGroup>
         <InputEntry
           label='Financial institution name'
@@ -46,4 +48,8 @@ function AddFinancialInstitution({
   );
 }
 
+AddFinancialInstitution.defaultProps = {
+  isLast: false,
+};
+
 export default AddFinancialInstitution;
diff --git a/src/pages/ProfileForm/CreateProfileForm/index.tsx b/src/pages/ProfileForm/CreateProfileForm/index.tsx
index 9caedcb0f..ba6bc8078 100644
--- a/src/pages/ProfileForm/CreateProfileForm/index.tsx
+++ b/src/pages/ProfileForm/CreateProfileForm/index.tsx
@@ -10,10 +10,10 @@ import FormWrapper from 'components/FormWrapper';
 
 import FormButtonGroup from 'components/FormButtonGroup';
 import FormMain from 'components/FormMain';
+import { Link } from 'components/Link';
 import LinkButton from 'components/LinkButton';
 import SectionIntro from 'components/SectionIntro';
-import { Button, Link } from 'design-system-react';
-import AdditionalDetails from 'pages/Filing/UpdateFinancialProfile/AdditionalDetails';
+import { Button } from 'design-system-react';
 import {
   emptyAddFinancialInstitution,
   formatUserProfileObject,
@@ -35,6 +35,8 @@ import { scenarios } from 'pages/Summary/Summary.data';
 
 import { useNavigate } from 'react-router-dom';
 
+import { sblHelpMail } from 'utils/common';
+import { One } from 'utils/constants';
 import { normalKeyLogic } from 'utils/getFormErrorKeyLogic';
 
 function CreateProfileForm(): JSX.Element {
@@ -124,11 +126,12 @@ function CreateProfileForm(): JSX.Element {
           <SectionIntro heading='Provide your financial institution details'>
             Provide the name and LEI of the financial institution for which you
             are authorized to file. If you are authorized to file for an
-            additional financial institution, click &ldquo;Add a financial
-            institution.&rdquo;
+            additional financial institution,{' '}
+            <Link href={sblHelpMail}>email our support staff</Link>.
           </SectionIntro>
           {fields.map((field, index) => {
             const onRemoveThisInstitution = (): void => remove(index);
+            const isLast = fields.length - One === index;
             return (
               <div className='flex flex-col' key={`${field.id}`}>
                 {index !== 0 && (
@@ -142,16 +145,18 @@ function CreateProfileForm(): JSX.Element {
                   index={index}
                   register={register}
                   formErrors={formErrors}
+                  isLast={isLast}
                 />
               </div>
             );
           })}
-          <div className='mb-[3.75rem]'>
+          {/* TODO: Re-enable button post-mvp */}
+          {/* https://github.com/cfpb/sbl-frontend/issues/596 */}
+          {/* <div className='mb-[3.75rem]'>
             <LinkButton onClick={onAppendFinancialInstitutions} icon='plus'>
-              Add a financial institution
+              Add an additional financial institution
             </LinkButton>
-          </div>
-          <AdditionalDetails isOptional register={register} />
+          </div> */}
           <FormButtonGroup>
             <Button
               appearance='primary'

From 9a09e9e26a6cd484f3225a651e89e94b46994c0d Mon Sep 17 00:00:00 2001
From: shindigira <shindigira@gmail.com>
Date: Wed, 29 May 2024 10:23:48 -0700
Subject: [PATCH 2/8] feat(complete user profile): toggle showing key index per
 error

---
 src/components/FormErrorHeader.tsx                | 8 +++++++-
 src/pages/ProfileForm/CreateProfileForm/index.tsx | 1 +
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/components/FormErrorHeader.tsx b/src/components/FormErrorHeader.tsx
index bf41c1af0..449eb1069 100644
--- a/src/components/FormErrorHeader.tsx
+++ b/src/components/FormErrorHeader.tsx
@@ -2,6 +2,7 @@ import { Alert, List, ListItem } from 'design-system-react';
 import type { PropsWithChildren } from 'react';
 import type { FieldErrors, FieldValues } from 'react-hook-form';
 import { Element, Link } from 'react-scroll';
+import { One } from 'utils/constants';
 
 import getAllProperties from 'utils/getAllProperties';
 import type { FormErrorKeyType } from 'utils/getFormErrorKeyLogic';
@@ -15,6 +16,7 @@ interface FormErrorHeaderProperties<
   errors?: FieldErrors<M>;
   alertHeading?: string;
   formErrorHeaderObject: T;
+  showKeyIndexNumber?: boolean;
 }
 
 /**
@@ -30,6 +32,7 @@ function FormErrorHeader<
   id,
   keyLogicFunc,
   formErrorHeaderObject,
+  showKeyIndexNumber,
 }: PropsWithChildren<FormErrorHeaderProperties<M, T>>): JSX.Element | null {
   if (!errors || Object.keys(errors).length === 0) return null;
 
@@ -100,7 +103,9 @@ function FormErrorHeader<
                         : 'Missing entry'
                     }${
                       // eslint-disable-next-line @typescript-eslint/no-magic-numbers
-                      typeof keyIndex === 'number' ? ` (${keyIndex + 1})` : ''
+                      showKeyIndexNumber && typeof keyIndex === 'number'
+                        ? ` (${keyIndex + One})`
+                        : ''
                     }`}
                   </Link>
                 </ListItem>
@@ -116,6 +121,7 @@ function FormErrorHeader<
 FormErrorHeader.defaultProps = {
   alertHeading: 'There was a problem completing your user profile',
   errors: null,
+  showKeyIndexNumber: false,
 };
 
 export default FormErrorHeader;
diff --git a/src/pages/ProfileForm/CreateProfileForm/index.tsx b/src/pages/ProfileForm/CreateProfileForm/index.tsx
index ba6bc8078..7a8b7ce0b 100644
--- a/src/pages/ProfileForm/CreateProfileForm/index.tsx
+++ b/src/pages/ProfileForm/CreateProfileForm/index.tsx
@@ -116,6 +116,7 @@ function CreateProfileForm(): JSX.Element {
           id={formErrorHeaderId}
           formErrorHeaderObject={CupNFFormHeaderErrors}
           keyLogicFunc={normalKeyLogic}
+          // showKeyIndexNumber -- re-enable post-mvp
         />
         <Step1FormInfoHeader />
         <FormMain>

From cf45bc09d50087d5553ede35070fd5966d9d0054 Mon Sep 17 00:00:00 2001
From: shindigira <shindigira@gmail.com>
Date: Wed, 29 May 2024 10:29:49 -0700
Subject: [PATCH 3/8] removed please

---
 src/pages/Summary/Summary.data.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pages/Summary/Summary.data.tsx b/src/pages/Summary/Summary.data.tsx
index 9118e0f9f..5d74412a0 100644
--- a/src/pages/Summary/Summary.data.tsx
+++ b/src/pages/Summary/Summary.data.tsx
@@ -126,7 +126,7 @@ function ChildrenSuccessInstitutionProfileUpdate(): JSX.Element {
   return (
     <>
       Please allow 24-48 hours for a response during normal business hours. If
-      you need further assistance please{' '}
+      you need further assistance{' '}
       <Link
         className={linkStyles}
         href='mailto:SBLHelp@cfpb.gov?subject=[BETA] Update your financial institution profile: Questions after submitting form'

From fca5e0397fa00c7db34136347c6ff6c385fbacd0 Mon Sep 17 00:00:00 2001
From: shindigira <shindigira@gmail.com>
Date: Wed, 29 May 2024 12:27:40 -0700
Subject: [PATCH 4/8] content(complete your user profile): updated header
 description language and gleif link

---
 .../ProfileForm/Step1Form/Step1FormHeader.tsx | 24 +++++++++++++++----
 src/utils/common.ts                           |  3 ++-
 2 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx b/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx
index 12bf51f79..156f809ed 100644
--- a/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx
+++ b/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx
@@ -1,7 +1,7 @@
 import FormHeaderWrapper from 'components/FormHeaderWrapper';
 import { Link } from 'components/Link';
 import { Paragraph, TextIntroduction } from 'design-system-react';
-import { gleifLink } from 'utils/common';
+import { gleifLink, sblHelpMail } from 'utils/common';
 
 interface Step1FormHeaderProperties {
   isStep1: boolean;
@@ -22,10 +22,24 @@ function Step1FormHeader({ isStep1 }: Step1FormHeaderProperties): JSX.Element {
         }
         description={
           <Paragraph>
-            In order to begin using the platform you must have a Legal Entity
-            Identifier (LEI) for your financial institution. Visit the{' '}
-            <Link href={gleifLink}>Global LEI Foundation (GLEIF)</Link> website
-            for more information on how to obtain an LEI.
+            {isStep1 ? (
+              <>
+                In order to begin using the platform you must have a Legal
+                Entity Identifier (LEI) for your financial institution. If your
+                organization does not have an LEI, visit the{' '}
+                <Link href={gleifLink}>Global LEI Foundation (GLEIF)</Link>{' '}
+                website.
+              </>
+            ) : (
+              <>
+                In order to begin using the platform you must have a Legal
+                Entity Identifier (LEI) for your financial institution. Visit
+                the <Link href={gleifLink}>Global LEI Foundation (GLEIF)</Link>{' '}
+                website for more information on how to obtain an LEI. If you
+                need assistance with this form,{' '}
+                <Link href={sblHelpMail}>email our support staff</Link>.
+              </>
+            )}
           </Paragraph>
         }
       />
diff --git a/src/utils/common.ts b/src/utils/common.ts
index 3fcebd293..2bc86bba1 100644
--- a/src/utils/common.ts
+++ b/src/utils/common.ts
@@ -2,7 +2,8 @@ export const sblHelpLink = 'https://sblhelp.consumerfinance.gov/';
 // TODO: replace this generic SBL Help link with a specific Salesforce form links
 // depending on the page and the form it should route to, see:
 // https://github.com/cfpb/sbl-frontend/issues/109
-export const gleifLink = 'https://www.gleif.org/';
+export const gleifLink =
+  'https://www.gleif.org/en/about-lei/get-an-lei-find-lei-issuing-organizations';
 export const loginGovAccountPage = 'https://secure.login.gov/account/';
 export const loginGovHomepage = 'https://login.gov/';
 export const filingInstructionsPage =

From 69e0bea853c73170323c2765fc129e979755632a Mon Sep 17 00:00:00 2001
From: shindigira <shindigira@gmail.com>
Date: Wed, 29 May 2024 17:44:54 -0700
Subject: [PATCH 5/8] content(complete your user profile): summary -- personal
 email address

---
 src/pages/Summary/Summary.data.tsx | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/pages/Summary/Summary.data.tsx b/src/pages/Summary/Summary.data.tsx
index 5d74412a0..71ad76746 100644
--- a/src/pages/Summary/Summary.data.tsx
+++ b/src/pages/Summary/Summary.data.tsx
@@ -99,7 +99,15 @@ function ChildrenError1(): JSX.Element {
       <Link className={linkStyles} href='/'>
         return to the platform homepage
       </Link>
-      , and sign in with your financial institution email address.
+      , and sign in with your financial institution email address. If this issue
+      persists,{' '}
+      <Link
+        className={linkStyles}
+        href='mailto:SBLHelp@cfpb.gov?subject=[BETA] Complete your user profile: Questions after submitting form'
+      >
+        email our support staff
+      </Link>
+      .
     </>
   );
 }

From aa5deacfe6f9a36148ae47ec483558a8ca862b2d Mon Sep 17 00:00:00 2001
From: shindigira <shindigira@gmail.com>
Date: Wed, 29 May 2024 18:09:49 -0700
Subject: [PATCH 6/8] enhancement(Summary): breadcrumb is standard for all
 summaries -- /landing or / routing

---
 src/pages/Summary/Summary.tsx | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/src/pages/Summary/Summary.tsx b/src/pages/Summary/Summary.tsx
index 7246995d4..f9938f54e 100644
--- a/src/pages/Summary/Summary.tsx
+++ b/src/pages/Summary/Summary.tsx
@@ -1,11 +1,11 @@
 import { useEffect } from 'react';
 
+import useSblAuth from 'api/useSblAuth';
 import CrumbTrail from 'components/CrumbTrail';
 import FormWrapper from 'components/FormWrapper';
 import { LoadingContent } from 'components/Loading';
 import { Link } from 'design-system-react';
 import type { Scenario } from 'pages/Summary/Summary.data';
-import { scenarios } from 'pages/Summary/Summary.data';
 import { useLocation, useNavigate } from 'react-router-dom';
 import SummaryContent from './SummaryContent';
 
@@ -18,6 +18,10 @@ function Summary(): JSX.Element | null {
     window.scrollTo({ top: 0 });
   }, []);
 
+  const auth = useSblAuth();
+  const { isAuthenticated: userIsAuthenticated, isLoading: isAuthLoading } =
+    auth;
+
   const { state } = useLocation() as { state: ScenarioStateType };
   const navigate = useNavigate();
 
@@ -29,23 +33,20 @@ function Summary(): JSX.Element | null {
   }, [state, navigate]);
 
   // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-  if (!state?.scenario) {
+  if (!state?.scenario || isAuthLoading) {
     return <LoadingContent />;
   }
 
-  const isSuccessInstitutionProfileUpdate: boolean =
-    state.scenario === scenarios.SuccessInstitutionProfileUpdate;
+  const platformHomeLink = userIsAuthenticated ? '/landing' : '/';
 
   return (
     <main id='main'>
-      {isSuccessInstitutionProfileUpdate ? (
-        <CrumbTrail>
-          <Link isRouterLink href='/landing' key='home'>
-            Platform home
-          </Link>
-        </CrumbTrail>
-      ) : null}
-      <FormWrapper isMarginTop={!isSuccessInstitutionProfileUpdate}>
+      <CrumbTrail>
+        <Link isRouterLink href={platformHomeLink} key='home'>
+          Platform home
+        </Link>
+      </CrumbTrail>
+      <FormWrapper isMarginTop={false}>
         <SummaryContent scenario={state.scenario} />
       </FormWrapper>
     </main>

From c72f847a4f293ad336cb307956dbd6b870a026e0 Mon Sep 17 00:00:00 2001
From: shindigira <shindigira@gmail.com>
Date: Wed, 29 May 2024 18:26:06 -0700
Subject: [PATCH 7/8] fixed help link

---
 .../ProfileForm/Step1Form/Step1FormHeader.tsx | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx b/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx
index 156f809ed..d533ebc8e 100644
--- a/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx
+++ b/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx
@@ -1,7 +1,7 @@
 import FormHeaderWrapper from 'components/FormHeaderWrapper';
 import { Link } from 'components/Link';
 import { Paragraph, TextIntroduction } from 'design-system-react';
-import { gleifLink, sblHelpMail } from 'utils/common';
+import { gleifLink } from 'utils/common';
 
 interface Step1FormHeaderProperties {
   isStep1: boolean;
@@ -27,17 +27,28 @@ function Step1FormHeader({ isStep1 }: Step1FormHeaderProperties): JSX.Element {
                 In order to begin using the platform you must have a Legal
                 Entity Identifier (LEI) for your financial institution. If your
                 organization does not have an LEI, visit the{' '}
-                <Link href={gleifLink}>Global LEI Foundation (GLEIF)</Link>{' '}
+                <Link href={gleifLink} target='_blank'>
+                  Global LEI Foundation (GLEIF)
+                </Link>{' '}
                 website.
               </>
             ) : (
               <>
                 In order to begin using the platform you must have a Legal
                 Entity Identifier (LEI) for your financial institution. Visit
-                the <Link href={gleifLink}>Global LEI Foundation (GLEIF)</Link>{' '}
+                the{' '}
+                <Link href={gleifLink} target='_blank'>
+                  Global LEI Foundation (GLEIF)
+                </Link>{' '}
                 website for more information on how to obtain an LEI. If you
                 need assistance with this form,{' '}
-                <Link href={sblHelpMail}>email our support staff</Link>.
+                <Link
+                  href='mailto:SBLHelp@cfpb.gov?subject=[BETA] Complete your user profile: Questions after submitting form'
+                  target='_blank'
+                >
+                  email our support staff
+                </Link>
+                .
               </>
             )}
           </Paragraph>

From 78537e55bdd99bb6798d5b7aa7710af11108767a Mon Sep 17 00:00:00 2001
From: shindigira <shindigira@gmail.com>
Date: Thu, 30 May 2024 09:17:22 -0700
Subject: [PATCH 8/8] updated baed on figma

---
 .../ProfileForm/Step1Form/Step1FormHeader.tsx | 45 +++++++------------
 1 file changed, 16 insertions(+), 29 deletions(-)

diff --git a/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx b/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx
index d533ebc8e..a2dbd4943 100644
--- a/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx
+++ b/src/pages/ProfileForm/Step1Form/Step1FormHeader.tsx
@@ -22,35 +22,22 @@ function Step1FormHeader({ isStep1 }: Step1FormHeaderProperties): JSX.Element {
         }
         description={
           <Paragraph>
-            {isStep1 ? (
-              <>
-                In order to begin using the platform you must have a Legal
-                Entity Identifier (LEI) for your financial institution. If your
-                organization does not have an LEI, visit the{' '}
-                <Link href={gleifLink} target='_blank'>
-                  Global LEI Foundation (GLEIF)
-                </Link>{' '}
-                website.
-              </>
-            ) : (
-              <>
-                In order to begin using the platform you must have a Legal
-                Entity Identifier (LEI) for your financial institution. Visit
-                the{' '}
-                <Link href={gleifLink} target='_blank'>
-                  Global LEI Foundation (GLEIF)
-                </Link>{' '}
-                website for more information on how to obtain an LEI. If you
-                need assistance with this form,{' '}
-                <Link
-                  href='mailto:SBLHelp@cfpb.gov?subject=[BETA] Complete your user profile: Questions after submitting form'
-                  target='_blank'
-                >
-                  email our support staff
-                </Link>
-                .
-              </>
-            )}
+            <>
+              In order to begin using the platform you must have a Legal Entity
+              Identifier (LEI) for your financial institution. If your
+              organization does not have an LEI, visit the{' '}
+              <Link href={gleifLink} target='_blank'>
+                Global LEI Foundation (GLEIF)
+              </Link>{' '}
+              website. If you need assistance with this form,{' '}
+              <Link
+                href='mailto:SBLHelp@cfpb.gov?subject=[BETA] Complete your user profile: Questions after submitting form'
+                target='_blank'
+              >
+                email our support staff
+              </Link>
+              .
+            </>
           </Paragraph>
         }
       />