From 4a0a57e7f656fd7eccf559ca82d687ecc1cdadfc Mon Sep 17 00:00:00 2001
From: S T <shindigira@gmail.com>
Date: Fri, 31 May 2024 09:34:47 -0700
Subject: [PATCH] Removed 'Additional Details' from Complete your User Profile
 & Update your Financial Institution Profile (#592)

closes #577

## Note
- Zod schema and formatting helper functions will be kept in -- incase
of future use


## Changes
- chore(additional_details): removed just the UI elements

## How to test this PR

1. Test Complete your User Profile (No Associations) -- verify requests
still go through with the proper data body
2. Test Update your Financial Institution Profile -- verify requests
still go through with the proper data body

## Screenshots
<img width="407" alt="Screenshot 2024-05-29 at 3 58 24 AM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/3f0ebf30-8cb0-411c-864d-02afc65ed33d">
<img width="604" alt="Screenshot 2024-05-29 at 3 55 05 AM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/e48573f0-f377-4397-aa06-7e7e6d1803e5">
---
 src/pages/Filing/UpdateFinancialProfile/UfpForm.tsx | 3 ---
 src/pages/ProfileForm/CreateProfileForm/index.tsx   | 2 --
 2 files changed, 5 deletions(-)

diff --git a/src/pages/Filing/UpdateFinancialProfile/UfpForm.tsx b/src/pages/Filing/UpdateFinancialProfile/UfpForm.tsx
index d31650df8..88193be90 100644
--- a/src/pages/Filing/UpdateFinancialProfile/UfpForm.tsx
+++ b/src/pages/Filing/UpdateFinancialProfile/UfpForm.tsx
@@ -24,7 +24,6 @@ import type { InstitutionDetailsApiType } from 'types/formTypes';
 import { Five } from 'utils/constants';
 import { updateFinancialProfileKeyLogic } from 'utils/getFormErrorKeyLogic';
 import getIsRoutingEnabled from 'utils/getIsRoutingEnabled';
-import AdditionalDetails from './AdditionalDetails';
 import FinancialInstitutionDetailsForm from './FinancialInstitutionDetailsForm';
 import UpdateAffiliateInformation from './UpdateAffiliateInformation';
 import UpdateIdentifyingInformation from './UpdateIdentifyingInformation';
@@ -147,8 +146,6 @@ export default function UFPForm({
           {...{ register, formErrors, watch }}
           heading='Update your parent entity information'
         />
-        <AdditionalDetails {...{ register }} />
-
         <FormButtonGroup>
           <Button
             id='nav-submit'
diff --git a/src/pages/ProfileForm/CreateProfileForm/index.tsx b/src/pages/ProfileForm/CreateProfileForm/index.tsx
index 9caedcb0f..cc3c5ed22 100644
--- a/src/pages/ProfileForm/CreateProfileForm/index.tsx
+++ b/src/pages/ProfileForm/CreateProfileForm/index.tsx
@@ -13,7 +13,6 @@ import FormMain from 'components/FormMain';
 import LinkButton from 'components/LinkButton';
 import SectionIntro from 'components/SectionIntro';
 import { Button, Link } from 'design-system-react';
-import AdditionalDetails from 'pages/Filing/UpdateFinancialProfile/AdditionalDetails';
 import {
   emptyAddFinancialInstitution,
   formatUserProfileObject,
@@ -151,7 +150,6 @@ function CreateProfileForm(): JSX.Element {
               Add a financial institution
             </LinkButton>
           </div>
-          <AdditionalDetails isOptional register={register} />
           <FormButtonGroup>
             <Button
               appearance='primary'