Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Validation for uid field #12

Closed
hkeeler opened this issue Jul 20, 2023 · 0 comments · Fixed by #20
Closed

Add Validation for uid field #12

hkeeler opened this issue Jul 20, 2023 · 0 comments · Fixed by #20
Assignees
@aharjati

Comments

@hkeeler
Copy link
Member

hkeeler commented Jul 20, 2023 •
edited
Loading

Add validations for Unique identifier

Validations:
uid.invalid_text_length
uid.invalid_text_pattern

These validations will be handle on separate tickets:
uid.invalid_uid_lei : #11
uid.duplicates_in_dataset : #10

Acceptance Criteria:

  • Validations for uid have been added
  • Unit tests for new uid validations
  • Passing validations on good/bad test data
@nargis-sultani nargis-sultani self-assigned this Jul 20, 2023
@aharjati aharjati assigned aharjati and unassigned nargis-sultani Jul 21, 2023
@aharjati aharjati linked a pull request Jul 24, 2023 that will close this issue
add uid format and length validations #20
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aharjati aharjati

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add uid format and length validations cfpb/regtech-data-validator
3 participants
@hkeeler @aharjati @nargis-sultani