Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Closing Costs link in the Rate Checker page lands on a different page #532

Open
OrlandoSoto opened this issue Jul 27, 2015 · 8 comments
Open
Assignees
Labels

Comments

@OrlandoSoto
Copy link
Member

On the build server "owning-a-home/check-rates/"
The "closing costs" link seems to be pointing to:
http://www.consumerfinance.gov/askcfpb/139/what-are-closing-costs.html

But instead when I click on it, the browser lands in:
http://www.consumerfinance.gov/askcfpb/1845/what-fees-or-charges-are-paid-closing-and-who-pays-them.html

So the browser test fails the assertion as it correctly detects that we did not land in the URL we expected

A couple things we can do:

  • Change the expected URL browser test
  • Change the href attribute in the closing costs link

closingcosts

@OrlandoSoto OrlandoSoto self-assigned this Jul 27, 2015
@mthibos
Copy link
Contributor

mthibos commented Jul 27, 2015

@OrlandoSoto thanks for noticing!

I'm double checking, but that's probably because we have discontinued the original link and consolidated with the link where it's actually landing. If so, we should just change the link in the code (and test).

@OrlandoSoto
Copy link
Member Author

thanks @mthibos !

@mthibos
Copy link
Contributor

mthibos commented Jul 27, 2015

Yep, that's what's going on. The redirect is permanent.

@stephanieosan can you make that change in the code on build?

@stephanieosan
Copy link
Member

Yes, I can update the code and the test. @mthibos, this is the correct link, right?

http://www.consumerfinance.gov/askcfpb/1845/what-fees-or-charges-are-paid-closing-and-who-pays-them.html

@mthibos
Copy link
Contributor

mthibos commented Jul 27, 2015

yep!

@OrlandoSoto
Copy link
Member Author

@stephanieosan I updated the test in #534

@stephanieosan
Copy link
Member

Oh, nice! I will do nothing then 😄

@OrlandoSoto
Copy link
Member Author

Browser test fixed in OrlandoSoto@cd2b9ea

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants