From be724b29021af0b551e50b5042e928ca25e46551 Mon Sep 17 00:00:00 2001
From: Craig Comstock <craig.comstock@northern.tech>
Date: Thu, 5 Dec 2024 16:04:58 -0600
Subject: [PATCH 1/2] Adjusted cf-support for exotic UNIX platforms

head -c 8 doesn't work on hpux 11.23 that we test on currently

dd count=1 bs=8 should work on all UNIX systems

tr on solaris needs LC_CTYPE=C as it can't handle binary data.
Silence not found sysctl command where it is not present.

Ticket: ENT-9786
Changelog: title
---
 misc/cf-support | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/misc/cf-support b/misc/cf-support
index df7d1439b0..88ba2fb3b8 100755
--- a/misc/cf-support
+++ b/misc/cf-support
@@ -120,7 +120,7 @@ make_temp_dir()
   else
     # shellcheck disable=SC2021
     # ^^ legacy/POSIX requires square brackets
-    _tmp="/tmp/`tr -dc "[A-Z][a-z][0-9]" </dev/urandom | head -c 8`"
+    _tmp="/tmp/`LC_CTYPE=C tr -dc "[A-Z][a-z][0-9]" </dev/urandom | dd count=1 bs=8 2>/dev/null`"
     mkdir "$_tmp"
     echo "$_tmp"
   fi
@@ -150,7 +150,11 @@ mkdir -p "$tmpdir"
 
 echo "Analyzing CFEngine core dumps"
 _core_log="$tmpdir"/core-dump.log
-_sysctl_kernel_core_pattern="$(sysctl -n kernel.core_pattern)"
+if command -v sysctl >/dev/null; then
+  _sysctl_kernel_core_pattern="$(sysctl -n kernel.core_pattern)"
+else
+  _sysctl_kernel_core_pattern=""
+fi
 if expr "$_sysctl_kernel_core_pattern" : ".*/systemd-coredump.*" > /dev/null 2>&1; then
   echo "Found systemd-coredump used in sysctl kernel.core_pattern \"$_sysctl_kernel_core_pattern\""
   echo "Using coredumpctl to analyze CFEngine core dumps"

From feede7c26cbdcb38c92ae9b3727a067a8f5942d1 Mon Sep 17 00:00:00 2001
From: Craig Comstock <craig.comstock@northern.tech>
Date: Mon, 9 Dec 2024 16:12:00 -0600
Subject: [PATCH 2/2] Adjusted cf-support to not fail if core dumps are
 available and gdb is missing

Previously cf-support would fail if core dumps were present and gdb was missing.

We only want a warning and a log of which files are available for anlysis in this case.

Ticket: ENT-9786
Changelog: title
---
 misc/cf-support | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/misc/cf-support b/misc/cf-support
index 88ba2fb3b8..bde06f1a18 100755
--- a/misc/cf-support
+++ b/misc/cf-support
@@ -194,17 +194,21 @@ else
       if [ "$OS" != "solaris" ]; then
         if ! command -v gdb >/dev/null; then
           echo "Please install gdb. This is required in order to analyze core dumps."
-          exit 1
+          echo "Core dumps needing to be analyzed will be listed below:"
         fi
       fi
       for core_file in $cf_core_files; do
         file "$core_file" >> "$_core_log"
         if [ "$OS" = "solaris" ]; then
           pstack "$core_file" >> "$_core_log" 2>&1
-        else
+        elif command -v gdb >/dev/null; then
           execfn=`file "$core_file" | sed 's/,/\n/g' | grep execfn | cut -d: -f2 | sed "s/[' ]//g"`
           exe="`realpath "$execfn"`"
           gdb "$exe" --core="$core_file" -batch -ex "thread apply all bt full" >> "$_core_log" 2>&1
+        else
+          echo "gdb not found so logging found core dump files to $_core_log"
+          # shellcheck disable=SC2012
+          ls -l "$core_file" | tee "$_core_log"
         fi
       done
     fi